This repository has been archived by the owner on Oct 4, 2022. It is now read-only.
Strip out question mark and hash characters from the snippet preview … #1486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CR 👍 |
|
Accpetance 👍 |
abotteram
deleted the
stories/af/485-snippetpreview-breadcrumbs-url-parse-no-query-hash
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
n/a
Relevant technical choices:
For consistency with the React snippet preview, see Yoast/yoast-components#495
Strips out any
?and#from the snippet preview URL.Test instructions
This PR can be tested by following these steps:
?and#characters?and#and with no missing partsFixes Yoast/yoast-components#485