Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip out question mark and hash characters from the snippet preview … #495

Conversation

afercia
Copy link
Contributor

@afercia afercia commented May 4, 2018

Strips out any ? and # from the snippet preview URL before passing it to node-url parse().

To test:

  • in the standalone example or yarn-link to wpseo:
  • if testing on WordPress, make sure your wp-config.php sets the constant define( 'YOAST_FEATURE_SNIPPET_PREVIEW', true );
  • if testing on WordPress, build the wpseo plugin js
  • edit the snippet preview
  • in the slug field, enter a slug that contains ? and # characters
  • check the slug in the snippet preview is rendered correctly, without ? and # and with no missing parts

Fixes #485

@abotteram
Copy link
Contributor

CR 👍

@abotteram
Copy link
Contributor

Acceptance 👍

@abotteram abotteram merged commit 6b113cd into develop May 7, 2018
@abotteram abotteram modified the milestones: Snippet Preview, 3.6 May 7, 2018
@abotteram abotteram deleted the stories/af/485-snippetpreview-breadcrumbs-url-parse-no-query-hash branch May 7, 2018 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants