Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix metabox on taxonomy pages when running Gutenberg master version. #12613

Closed
wants to merge 2 commits into from
Closed

Fix metabox on taxonomy pages when running Gutenberg master version. #12613

wants to merge 2 commits into from

Conversation

herregroen
Copy link
Contributor

@herregroen herregroen commented Apr 8, 2019 •
edited by Djennez
Loading

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an issue where the metabox would not display on term edit pages when running the development build of Gutenberg.

Relevant technical choices:

  • In the development build of Gutenberg wp.data is loaded on term edit pages but the core/editor selectors are not registered. This causes null to be returned which is then compared to undefined causing us to wrongly assume Gutenberg is fully available.

Test instructions

This PR can be tested by following these steps:

  • Checkout Gutenberg master, build plugin and activate it.
  • Go to create new Category.
  • You should see the metabox and it should work as expected.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #12540
Fixes #12590

@moorscode moorscode changed the base branch from trunk to release/11.0 April 8, 2019 12:50
@moorscode moorscode changed the base branch from release/11.0 to trunk April 8, 2019 12:50
@moorscode moorscode mentioned this pull request Apr 8, 2019
Closed
3 tasks
@moorscode
Copy link
Contributor

Cherry-picked the commits to the release branch, closing this PR.

@moorscode moorscode closed this Apr 8, 2019
@moorscode moorscode deleted the 12540-fix-metabox-on-taxonomy-edit branch April 8, 2019 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@herregroen @moorscode