Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12540 fix gutenberg type check #12614

Closed
wants to merge 2 commits into from

Conversation

moorscode
Copy link
Contributor

@moorscode moorscode commented Apr 8, 2019

Summary

This PR can be summarized in the following changelog entry:

  • Fixes an issue where the metabox would not display on term edit pages when running the development build of Gutenberg.

Relevant technical choices:

  • In the development build of Gutenberg wp.data is loaded on term edit pages but the core/editor selectors are not registered. This causes null to be returned which is then compared to undefined causing us to wrongly assume Gutenberg is fully available.

Test instructions

This PR can be tested by following these steps:

  • Checkout Gutenberg master, build plugin and activate it.
  • Go to create new Category.
  • You should see the metabox and it should work as expected.

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Quality assurance

  • I have tested this code to the best of my abilities
  • I have added unittests to verify the code works as intended

Fixes #12540

Replaces #12613

@moorscode moorscode added this to the 11.0 milestone Apr 8, 2019
@IreneStr
Copy link
Contributor

IreneStr commented Apr 8, 2019

CR 👍

@IreneStr
Copy link
Contributor

IreneStr commented Apr 9, 2019

Acceptance 👎

#12590 is not fixed. I still have an empty metabox, and see the following errors:

Schermafbeelding 2019-04-09 om 15 12 38

@IreneStr
Copy link
Contributor

Acceptance 👍

@IreneStr
Copy link
Contributor

These commits have been cherrypicked to the new 11.0 releasebranch.

@IreneStr IreneStr closed this Apr 11, 2019
@IreneStr IreneStr deleted the 12540-fix-gutenberg-type-check branch April 11, 2019 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants