Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FTC: remove fixed width and HR #21754

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

igorschoester
Copy link
Member

@igorschoester igorschoester commented Oct 28, 2024

Context

Summary

This PR can be summarized in the following changelog entry:

  • Fixes a bug where the First time configuration would not resize properly on smaller width screens.
  • Fixes a bug where the First time configuration would have a double separator for the title and content.

Relevant technical choices:

Make indexation step responsive
The hardcoded width is preventing collapsing. But it was already moving the image below it.
So I really don't see a need for the width, instead lets try to take a similar amount of space if available.
But don't prevent it from being smaller.

Test instructions

Test instructions for the acceptance test before the PR gets merged

This PR can be acceptance tested by following these steps:

  • Go to the First time configuration
  • Play around with the screen size
  • Verify it now shrinks properly and has no more horizontal scrolling
    • In particular it is regarding the SEO data optimization (first) step's description and image.

Relevant test scenarios

  • Changes should be tested with the browser console open
  • Changes should be tested on different posts/pages/taxonomies/custom post types/custom taxonomies
  • Changes should be tested on different editors (Default Block/Gutenberg/Classic/Elementor/other)
  • Changes should be tested on different browsers
  • Changes should be tested on multisite

Test instructions for QA when the code is in the RC

  • QA should use the same steps as above.

QA can test this PR by following these steps:

Impact check

This PR affects the following parts of the plugin, which may require extra testing:

  • The FTC styling

UI changes

  • This PR changes the UI in the plugin. I have added the 'UI change' label to this PR.

Other environments

  • This PR also affects Shopify. I have added a changelog entry starting with [shopify-seo], added test instructions for Shopify and attached the Shopify label to this PR.

Documentation

  • I have written documentation for this change. For example, comments in the Relevant technical choices, comments in the code, documentation on Confluence / shared Google Drive / Yoast developer portal, or other.

Quality assurance

  • I have tested this code to the best of my abilities.
  • During testing, I had activated all plugins that Yoast SEO provides integrations for.
  • I have added unit tests to verify the code works as intended.
  • If any part of the code is behind a feature flag, my test instructions also cover cases where the feature flag is switched off.
  • I have written this PR in accordance with my team's definition of done.
  • I have checked that the base branch is correctly set.

Innovation

  • No innovation project is applicable for this PR.
  • This PR falls under an innovation project. I have attached the innovation label.
  • I have added my hours to the WBSO document.

Fixes https://github.com/Yoast/reserved-tasks/issues/295

We already have a border to separate the title/description from the content
The hardcoded width is preventing collapsing. But it was already moving the image below it.
So I really don't see a need for the width, instead lets try to take a similar amount of space if available.
But don't prevent it from being smaller.
@igorschoester igorschoester added UI change PRs that result in a change in the UI changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog labels Oct 28, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build cca349042c8777c50a79ee74c3d59adb2668e630

Details

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+13.5%) to 54.575%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/js/src/first-time-configuration/tailwind-components/steps/indexation/indexation-step.js 0 1 0.0%
Totals Coverage Status
Change from base Build a4019d916ecde33fdc49ec99bba91f3498760793: 13.5%
Covered Lines: 29672
Relevant Lines: 54638

💛 - Coveralls

@thijsoo thijsoo added this to the 23.9 milestone Oct 28, 2024
Copy link
Contributor

@thijsoo thijsoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR + ACC 👍

@thijsoo thijsoo merged commit e77fc96 into trunk Oct 28, 2024
16 checks passed
@thijsoo thijsoo deleted the 295-ftc-is-broken-in-mobile-for-the-new-dashboard branch October 28, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog: bugfix Needs to be included in the 'Bugfixes' category in the changelog UI change PRs that result in a change in the UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants