Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTC: remove fixed width and HR #21754

Merged
merged 2 commits into from
Oct 28, 2024
Merged

FTC: remove fixed width and HR #21754

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e41e41b
FTC: remove horizontal rule
igorschoester Oct 24, 2024
0bf6151
Make indexation step responsive
igorschoester Oct 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions ...s/js/src/first-time-configuration/tailwind-components/steps/indexation/indexation-step.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,9 @@
import { Fragment } from "@wordpress/element";
import { __ } from "@wordpress/i18n";
import PropTypes from "prop-types";
import { ReactComponent as ConfigurationStartImage } from "../../../../../images/indexables_1_left_bubble_optm.svg";
import { FadeInAlert } from "../../base/alert";
import { ConfigurationIndexation } from "./configuration-indexation";

/* eslint-disable complexity */

/**
* The indexation step.
*
Expand All @@ -18,17 +15,17 @@ import { ConfigurationIndexation } from "./configuration-indexation";
* @returns {WPElement} The indexation step.
*/
export default function IndexationStep( { indexingState, setIndexingState, showRunIndexationAlert, isStepperFinished } ) {
return <Fragment>
<div className="yst-flex yst-flex-row yst-justify-between yst-flex-wrap yst-mb-8">
<p className="yst-text-sm yst-whitespace-pre-line yst-w-[463px]">
return <div className="yst-@container">
<div className="yst-flex yst-flex-col @lg:yst-flex-row yst-gap-6 yst-mb-8">
<p className="yst-text-sm yst-whitespace-pre-line">
{ __(
"Let's start by running the SEO data optimization. That means we'll scan your site and create a database with " +
"optimized SEO data. It won't change any content or settings on your site and you don't need to do anything, just hit start!\n" +
"\nNote: If you have a lot of content, this optimization could take a moment. But trust us, it's worth it!",
"wordpress-seo"
) }
</p>
<ConfigurationStartImage className="yst-h-28 yst-w-24 yst-mr-6" />
<ConfigurationStartImage className="yst-shrink-0 yst-h-28 yst-w-24" />
</div>
<div id="yoast-configuration-indexing-container" className="indexation-container">
<ConfigurationIndexation
Expand All @@ -48,7 +45,7 @@ export default function IndexationStep( { indexingState, setIndexingState, showR
"wordpress-seo" )
}
</FadeInAlert>
</Fragment>;
</div>;
}

IndexationStep.propTypes = {
Expand Down
1 change: 0 additions & 1 deletion packages/js/src/general/routes/first-time-configuration.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ const FirstTimeConfiguration = () => {
title={ __( "First-time configuration", "wordpress-seo" ) }
description={ __( "Tell us about your site, so we can get it ranked! Let's get your site in tip-top shape for the search engines. Follow these 5 steps to make Google understand what your site is about.", "wordpress-seo" ) }
>
<hr id="configuration-hr-top" />
<div id="yoast-configuration" className="yst-p-8 yst-max-w-[715px]">
<FirstTimeConfigurationSteps />
</div>
Expand Down