Adjust language notice for non admins #8333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afercia
reviewed
Nov 24, 2017
| }; | ||
|
|
||
| Results.defaultProps = { | ||
| language: "", | ||
| changeLanguageLink: "#", | ||
| canChangeLanguage: false, |
There was a problem hiding this comment.
question about changeLanguageLink not sure # is a proper default value now
There was a problem hiding this comment.
Merging for now. @xyfi Please address this when you're back.
afercia
reviewed
Nov 24, 2017
| @@ -55,7 +55,7 @@ function configureStore() { | |||
| function wrapInTopLevelComponents( Component, store ) { | |||
| return ( | |||
| <IntlProvider | |||
| locale={ localizedData.intl.locale } | |||
| locale={ localizedData.intl.locale.substr( 0, 2 ).toLowerCase() } | |||
There was a problem hiding this comment.
Not sure about the need of this change (not arguing, I just don't know the reason)
There was a problem hiding this comment.
Merging for now. @xyfi Please address this when you're back.
|
CR done 👍 |
|
Acceptance done 👍 |
andizer
deleted the
stories/384-adjust-language-notice-for-non-admins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Needs a release of
yoast-componentswith Yoast/yoast-components#389 merged.Fixes Yoast/yoast-components#384