Adjust language notice for non admins #389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
November 23, 2017 14:52
…nd change language notice accordingly
afercia
reviewed
Nov 24, 2017
| @@ -145,6 +145,45 @@ class ContentAnalysis extends React.Component { | |||
| } ); | |||
| } | |||
|
|
|||
| /** | |||
| * Render the language notice. Provides a link to a setting page in case of administrator, a notice to contact an | |||
afercia
reviewed
Nov 24, 2017
| renderLanguageNotice() { | ||
| let showLanguageNotice = this.props.showLanguageNotice; | ||
| let canChangeLanguage = this.props.canChangeLanguage; | ||
| if( ! showLanguageNotice ) { |
afercia
reviewed
Nov 24, 2017
| if( ! showLanguageNotice ) { | ||
| return null; | ||
| } | ||
| if( canChangeLanguage ) { |
afercia
reviewed
Nov 24, 2017
| id="content-analysis.language-notice" | ||
| defaultMessage="Your site language is set to {language}." | ||
| values={ { language: <strong>{ this.props.language }</strong> } } /> | ||
| { " " } |
There was a problem hiding this comment.
minor: instead of explicitly using a space, I'd consider to use a translatable string that merges the 2 existing ones
|
CR done 👍 |
|
Acceptance done |
IreneStr
deleted the
stories/384-adjust-language-notice-for-non-admins
branch
IreneStr
added a commit
that referenced
this pull request
Nov 27, 2017
Added * Made it possible to pass the heading level of the `analysisCollapsible`s as a prop to the `ContentAnalysis`. #388 * Added a language notice in the content analysis for non-admin users that cannot change the language. #389 Fixed - Avoid to fully re-render the `AnalyisisCollapsible` component to improve accessibility #386 - Fixed alignment of icons and text in the `ContentAnalysis` component. #390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
This PR can be tested by following these steps:
Fixes #384