Install gowin_pll tool #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd rather wrap it in a main function and add the usual if name == main
like the other scripts
…On Fri, 4 Aug 2023, 16:47 Catherine ***@***.***> wrote:
@whitequark <https://github.com/whitequark> requested your review on: #192
<#192> Install gowin_pll tool.
—
Reply to this email directly, view it on GitHub
<#192 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABJFIKEQPCGEFOSXDN4RQ3XTUDQPANCNFSM6AAAAAA3EKBCYY>
.
You are receiving this because your review was requested.Message ID:
***@***.***>
|
Fixes #191.
whitequark
force-pushed
the
install-gowin_pll
branch
from
9b0835a
to
5de2702
Compare
|
Done |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #191.
I implemented this in a somewhat cursed way where it does
sys.exit(0)because otherwise the caller (the script installed by setuptools) would crash trying to call the module. This minimizes the diff though.