Refactor dat parser #212
Merged
Refactor dat parser #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Other than CI failing it seems like an improvement |
|
I forgot to commit some silly changes 😁 |
|
Looks like things pass. I'll try to find some time to review and test on hardware and merge. |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a mostly-mechanical translation of the current code, without attempting to find higher level abstractions that could make the code shorter.
I've made up some names, as I don't really know what names should be assigned to these groupings
There are 4 fields which are used from the .dat files:
I've left everything else, mostly-compatible, within
compat_dict. There are a few very small changes, such as having indexes as integers (CmuxIns[94]instead ofCmuxIns["94"]).The new implementation also contains this potential bugfix: fdc77a8