Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regex #259

Merged
merged 1 commit into from
Jul 15, 2024
Merged

Fix regex #259

merged 1 commit into from
Jul 15, 2024

Conversation

max-kudinov
Copy link
Contributor

Fixed regex for shorting device name, so it would work with GW2A series.

Also renamed luts to num, because this number doesn't necessarily represent number of luts (18 for 20k LUTs chip)

@pepijndevos
Copy link
Member

Great work!

Maybe we should update the makefile with the chip name to test this change?

gowin_pack -d GW2A-18C -o $@ $<

@max-kudinov
Copy link
Contributor Author

Great work!

Maybe we should update the makefile with the chip name to test this change?

gowin_pack -d GW2A-18C -o $@ $<

It seems that this makefile uses short names for all chips, including GW1N*. In that case I think that all names should be changed to their full version, not just GW2A. What do you think about it?

And by the way, what's the difference between examples and examples/himbaechel directories?

@pepijndevos
Copy link
Member

Eh that's fair. It could be a useful change, but could be a separate PR.

The difference is example uses nextpnr-gowin while examples/himbaechel uses that.

@pepijndevos pepijndevos merged commit 9d37e71 into YosysHQ:master Jul 15, 2024
12 of 14 checks passed
@max-kudinov
Copy link
Contributor Author

Then the names should be changed in both examples and examples/himbaechel makefiles, cause gowin_pack call is the same. I can make a separate PR with it.

@max-kudinov max-kudinov deleted the fix_regex branch July 15, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants