Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make icebox.py executable #297

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Xiretza
Copy link

@Xiretza Xiretza commented May 14, 2022

f4pga-arch-defs expects to find an executable called icebox.py on the PATH, and while the file exists, it is not marked +x, so configuration fails.

@lethalbit
Copy link
Member

It might be better to ensure the install step marks the file as executable as opposed to setting +x directly on the file itself, as there is potential for the executable flag to be cleared if, for instance, it is first moved onto an NTFS file system.

So it might be better to add the executable bit to the install step in the Makefile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants