Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working #16

Closed
sunneo opened this issue Oct 28, 2019 · 11 comments · Fixed by #18
Closed

Not working #16

sunneo opened this issue Oct 28, 2019 · 11 comments · Fixed by #18
Labels
bug Something isn't working

Comments

@sunneo
Copy link

sunneo commented Oct 28, 2019

你遇到了什麼問題?
not work

請詳細的描述一下
打開extension後狀態一直在loading,按下refresh按鈕,得到錯誤"ptt.refresh-article not found"
文章沒有顯示出來

如何重現
0. 環境: Ubuntu 18.04 64bit xfce (xubuntu 18.04)

  1. NoMachine to remote host
  2. Open VsCode
  3. install extension
  4. open extension 'vscode-ptt'
  5. done.

使用環境
Xubuntu 18.04
vscode installed from snap
install vscode-ptt from https://marketplace.visualstudio.com/items?itemName=Yukai.vscode-ptt&ssr=false#qna

  • vscode-ptt 版本: 0.3.1
  • VSCode 版本: 1.36.2
  • 作業系統: Linux
@brianchul
Copy link

相同問題 無法登入
點選更多功能僅顯示這個
螢幕快照 2019-10-28 下午1 51 45

macOS 10.14.6
Vscode 版本: 1.39.2
vscode-ptt 版本: 0.3.1

@JosephT5566
Copy link
Contributor

稍微試了一下,似乎是ptt-client中的login,在最近的更新之後無法連線@@

@Yukaii
Copy link
Owner

Yukaii commented Oct 28, 2019

可能是最近站方開始限制 websocket 的 origin 了 😅 剛好這兩天關了一個 PR (隨便猜猜)

要試試把 origin 換成 ^app:// 看有沒有救 🤣

ptt/pttbbs@de63cdf#diff-aed484195b5021a9cbbe97cff74bbeddR31

@Yukaii Yukaii added the bug Something isn't working label Oct 28, 2019
@Yukaii
Copy link
Owner

Yukaii commented Oct 28, 2019

是很想上 upstream 標籤啦,不過這應該是 upstream 的 upstream 的問題,說起來這不就是 origin 嗎(冷

@Yukaii
Copy link
Owner

Yukaii commented Oct 29, 2019

發現 ptt-client 預設的 origin 就是 www.ptt.cc 了,看來問題不是在這呢 😂

https://github.com/kevinptt0323/ptt-client/blob/master/src/sites/ptt/config.ts

記得 keven 和我提過其實不用再搭一個 proxy,要試試看移掉會如何

@JosephT5566
Copy link
Contributor

試著不傳入proxy來new ptt實體,看來是會直接採用預設的origin來建立,應該是沒問題
不過在login那邊還是不行呢~ 或許真的是websocket QQ

@mikeqoo1
Copy link

我也有相同問題

image

CentOS Linux release 7.7.1908 (Core)
vscode 版本: 1.39.2
vscode-ptt 版本: 0.3.1

@kevinptt0323
Copy link

kevinptt0323 commented Oct 30, 2019

可能是最近站方開始限制 websocket 的 origin 了 sweat_smile 剛好這兩天關了一個 PR (隨便猜猜)

* [ptt/pttbbs#24](https://github.com/ptt/pttbbs/pull/24)

* [ptt/pttbbs@de63cdf](https://github.com/ptt/pttbbs/commit/de63cdf1cff06b317a1e3597423c1dd8a3279fc6)

要試試把 origin 換成 ^app:// 看有沒有救 rofl

ptt/pttbbs@de63cdf#diff-aed484195b5021a9cbbe97cff74bbeddR31

我試了一下是可以的,怕未來被卡的話,就用 app://pcman 吧XD

kevinptt0323/ptt-ws-proxy@b47bd7c

@Yukaii
Copy link
Owner

Yukaii commented Oct 30, 2019

@kevinptt0323 太帥啦!!

@kevinptt0323
Copy link

https://github.com/Yukaii/vscode-ptt/blob/master/src/proxy.ts#L17

(應該)是你這邊要改哦

@Yukaii
Copy link
Owner

Yukaii commented Oct 31, 2019

v0.3.2 版本已發佈!

https://marketplace.visualstudio.com/items?itemName=Yukai.vscode-ptt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants