Add Welly to origin whitelist #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Welly now supports Websocket connection. It would be great if it can use its own application identity. It might also be helpful for PTT admin to differentiate WSS traffic.
|
I have a plan to make this configurable, so the source code can be separated from operations. I will make this open until I've done this. |
|
@robertabcd it's one year after, so do you have any plan to move on? Or should we just merge, or close this PR? |
wens
force-pushed
the
master
branch
4 times, most recently
from
82f20a6 to
c1ad910
Compare
|
Origin check is now detached from the source code into nginx config as de63cdf. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welly now supports Websocket connection. It would be great if it can use its own application identity. It might also be helpful for PTT admin to differentiate WSS traffic by clients.