Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade synapse to 0.99.5.2 #131

Merged
merged 1 commit into from
Jun 10, 2019
Merged

Upgrade synapse to 0.99.5.2 #131

merged 1 commit into from
Jun 10, 2019
+6 −6

Conversation

Josue-T
Copy link

@Josue-T Josue-T commented May 30, 2019 •
edited by kay0u
Loading

Problem

  • The package is not up to date

Solution

  • Update the package

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review : JimboJoe
  • Approval (LGTM) : JimboJoe
  • Approval (LGTM) : Kay0u
  • CI succeeded :
    Build Status

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@Josue-T Josue-T requested a review from a team May 30, 2019 22:32
JimboJoe
JimboJoe approved these changes May 31, 2019
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and code review OK 👍

@JimboJoe JimboJoe requested a review from a team May 31, 2019 13:32
@Josue-T Josue-T requested review from a team and removed request for a team June 2, 2019 11:28
kay0u
kay0u approved these changes Jun 5, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kay0u
Copy link
Member

kay0u commented Jun 5, 2019

Can be merged in 3 days

@Thatoo
Copy link

Thatoo commented Jun 10, 2019

Can be merged today, right? Before the release of v1 would be great, no?

@Josue-T Josue-T merged commit 3dbac39 into testing Jun 10, 2019
@Josue-T Josue-T deleted the v0.99.5.2 branch June 10, 2019 19:06
@Josue-T
Copy link
Author

Josue-T commented Jun 10, 2019

Can be merged today, right? Before the release of v1 would be great, no?

Yes and no, this PR is not mandatory to be able to be compatible with the synapse v1 version.

@MayeulC
Copy link

MayeulC commented Jun 15, 2019 •
edited
Loading

While that's true, I had some issues with forward extremities that forced me to reboot my server (OOM, swapping). I believe I've hit the following issue, which this PR should fix:

matrix-org/synapse#5269

I'd suggest other heavy Matrix users to pre-emptively check if they haven't been building up extremities: matrix-org/synapse#1760
(run the postgres prompt with su --command="psql matrix_synapse" postgres as stated in the readme :))

For reference, I had 182 extremities in #freenode_#archlinux:matrix.org in the previous situation. Extremities are still building up quite quickly :/

@MayeulC MayeulC mentioned this pull request Jun 25, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimboJoe JimboJoe JimboJoe approved these changes

@kay0u kay0u kay0u approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Josue-T @kay0u @Thatoo @MayeulC @JimboJoe