Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

V1.0 #132

Merged
merged 3 commits into from
Jul 11, 2019
Merged

V1.0 #132

merged 3 commits into from
Jul 11, 2019

Conversation

Josue-T
Copy link

@Josue-T Josue-T commented Jun 13, 2019 •
edited
Loading

Problem

  • The package is not up to date

Solution

  • Update the package

PR Status

  • Code finished.
  • Tested with Package_check.
  • Fix or enhancement tested.
  • Upgrade from last version tested.
  • Can be reviewed and tested.

Validation

Minor decision

  • Upgrade previous version :
  • Code review :
  • Approval (LGTM) :
  • Approval (LGTM) :
  • CI succeeded :
    Build Status

When the PR is marked as ready to merge, you have to wait for 3 days before really merging it.

@Josue-T Josue-T requested a review from a team June 13, 2019 08:50
@Josue-T Josue-T mentioned this pull request Jun 13, 2019
Closed
@Thatoo
Copy link

Thatoo commented Jun 13, 2019

I checked the files changed and almost everything looks good to me except that I can't download https://github.com/YunoHost-Apps/synapse_python_build/releases/download/v1.0.0/matrix-synapse_1.0.0-jessie-bin1_armv7l.tar.gz
thus I can't checksum it.

@Josue-T
Copy link
Author

Josue-T commented Jun 13, 2019

Well, the last version of synapse don't run in Jessie. 😕
See https://github.com/YunoHost-Apps/synapse_ynh/blob/testing/manifest.json

@Thatoo
Copy link

Thatoo commented Jun 13, 2019

OK. So, as we can assume that future version won't run on Jessie neither, why not deleting the file armv7_jessie.src ?
Maybe it's a naive question.

@Josue-T
Copy link
Author

Josue-T commented Jun 13, 2019

Because it's forgotten. But it's done here just need to merge this PR, one day...

@MayeulC
Copy link

MayeulC commented Jun 25, 2019

Hmm, what is the status on this one?

I have had to manually prune extremities four times the past week, which isn't a pleasant experience:

  • I needed to reboot my server once, as it was swapping so much I couldn't ssh in
  • I missed a few messages snapse didn't try to backfill
  • performance has been pretty bad overall for every service on my server (swapping...)

See more details in the following comment: #131 (comment)

But I think either #131 or this one should substantially improve performance with regards to this, pending the upcoming improvements to extremities management and the small HS case.

@Josue-T
Copy link
Author

Josue-T commented Jun 26, 2019

We need to relaunch the CI probably...

JimboJoe
JimboJoe previously approved these changes Jun 29, 2019
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and code review OK 👍

@JimboJoe
Copy link

Btw, I just relaunched the CI.

@JimboJoe JimboJoe requested a review from a team June 29, 2019 20:41
kay0u
kay0u previously approved these changes Jul 4, 2019
View reviewed changes
@Josue-T Josue-T dismissed stale reviews from kay0u and JimboJoe via 81faa5b July 5, 2019 10:15
@Josue-T Josue-T requested review from a team, JimboJoe and kay0u July 5, 2019 11:46
JimboJoe
JimboJoe approved these changes Jul 5, 2019
View reviewed changes
Copy link

@JimboJoe JimboJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and code review OK 👍

@kay0u kay0u mentioned this pull request Jul 6, 2019
Closed
@kay0u
Copy link
Member

kay0u commented Jul 6, 2019

Are you sure you want to merge it on master?

@Josue-T Josue-T changed the base branch from master to testing July 7, 2019 19:47
@Josue-T
Copy link
Author

Josue-T commented Jul 7, 2019 •
edited
Loading

Are you sure you want to merge it on master?

Oh bad, should be fixed now... we should merge this on testing

kay0u
kay0u approved these changes Jul 7, 2019
View reviewed changes
Copy link
Member

@kay0u kay0u left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kay0u
Copy link
Member

kay0u commented Jul 7, 2019

Can be merged in 3 days

@Josue-T Josue-T merged commit 4dd0b51 into testing Jul 11, 2019
@Josue-T Josue-T deleted the v1.0 branch July 11, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kay0u kay0u kay0u approved these changes

@JimboJoe JimboJoe JimboJoe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Josue-T @Thatoo @MayeulC @JimboJoe @kay0u