Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network upgrade test blocks #1091

Closed
10 tasks done
oxarbitrage opened this issue Sep 23, 2020 · 2 comments · Fixed by #1096
Closed
10 tasks done

Network upgrade test blocks #1091

oxarbitrage opened this issue Sep 23, 2020 · 2 comments · Fixed by #1096
Assignees
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement

Comments

@oxarbitrage
Copy link
Contributor

oxarbitrage commented Sep 23, 2020

It will be useful to have encoded block vectors for all the network upgrades so we can unit test the consensus changes for each. Related to #1051

Ideally we should add 3 blocks per upgrade: NU-1, NU, and NU+1 for every network upgrade for mainnet and testnet.

This are the commands needed to be executed in a synchronized zcashd for blossom testnet(activation height: 584_000):

./src/zcash-cli getblock 583999 0
./src/zcash-cli getblock 584000 0
./src/zcash-cli getblock 584001 0

and blossom mainnet(activation height: 653_600)

./src/zcash-cli getblock 653599 0
./src/zcash-cli getblock 653600 0
./src/zcash-cli getblock 653601 0

Use https://github.com/ZcashFoundation/zebra/blob/main/zebra-chain/src/parameters/network_upgrade.rs#L44=L68 to get other heights.

TODO:

Networks

  • Mainnet
  • Testnet

Network Upgrades

  • Genesis
  • BeforeOverwinter
  • Overwinter
  • Sapling
  • Blossom
  • Heartwood
  • Canopy (Testnet only, until November)
@oxarbitrage oxarbitrage added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Sep 23, 2020
@teor2345 teor2345 self-assigned this Sep 23, 2020
@teor2345 teor2345 added A-rust Area: Updates to Rust code E-easy and removed S-needs-triage Status: A bug report needs triage labels Sep 23, 2020
@teor2345
Copy link
Contributor

I'd also like to have lists of Mainnet / Testnet blocks, and maybe blocks for each network upgrade, and all blocks.

@teor2345
Copy link
Contributor

I'd also like to have lists of Mainnet / Testnet blocks, and maybe blocks for each network upgrade, and all blocks.

I just went with the list of all blocks, we can make more specific lists if we need them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants