Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test blocks #1096

Merged
merged 10 commits into from
Sep 28, 2020
Merged

Test blocks #1096

merged 10 commits into from
Sep 28, 2020

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Sep 24, 2020 •
edited
Loading

Closes #1091.

TODO:

  • Testnet Overwinter to Canopy

@teor2345 teor2345 added E-med A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement C-cleanup Category: This is a cleanup labels Sep 24, 2020
@teor2345 teor2345 requested review from oxarbitrage and a team September 24, 2020 13:46
@teor2345 teor2345 self-assigned this Sep 24, 2020
@teor2345
Copy link
Contributor Author

@oxarbitrage I just did the mainnet blocks today - it took longer than I thought.

Hopefully that's enough to get you started.

@dconnolly
Copy link
Contributor

@teor2345 is this still a draft?

dconnolly
dconnolly previously approved these changes Sep 25, 2020
View reviewed changes
@teor2345
Copy link
Contributor Author

@teor2345 is this still a draft?

Yeah it's missing the testnet blocks for each network upgrade - particularly Canopy, which we can't test with mainnet blocks, because they don't exist yet.

@teor2345 teor2345 marked this pull request as ready for review September 25, 2020 05:56
@teor2345 teor2345 requested a review from a team September 25, 2020 05:56
@teor2345 teor2345 mentioned this pull request Sep 25, 2020
Closed
9 tasks
oxarbitrage
oxarbitrage approved these changes Sep 25, 2020
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@teor2345 teor2345 merged commit 6f371f3 into ZcashFoundation:main Sep 28, 2020
@teor2345 teor2345 mentioned this pull request Sep 28, 2020
Closed
51 tasks
@oxarbitrage oxarbitrage mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oxarbitrage oxarbitrage oxarbitrage approved these changes

@dconnolly dconnolly dconnolly approved these changes

Assignees

@teor2345 teor2345

Labels
A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup C-enhancement Category: This is an improvement
Projects
None yet
Milestone
Block Validation
Development

Successfully merging this pull request may close these issues.

Network upgrade test blocks
3 participants
@teor2345 @dconnolly @oxarbitrage