Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Testnet Post-Halving Block Test Vectors #1104

Closed
9 tasks done
teor2345 opened this issue Sep 28, 2020 · 2 comments · Fixed by #1910
Closed
9 tasks done

Add Testnet Post-Halving Block Test Vectors #1104

teor2345 opened this issue Sep 28, 2020 · 2 comments · Fixed by #1910
Assignees
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Milestone

Comments

@teor2345
Copy link
Contributor

teor2345 commented Sep 28, 2020

In #1091, we added block test vectors for each network upgrade transition.

The Testnet block subsidy halves on Testnet at block 1_116_000. We want to add post-halving Testnet test vectors around 13 October 2020, after the first halving. (The first Mainnet halving is at Canopy activation, so it is covered by #1099.)

Preconditions:

  • The block subsidy has halved on Testnet (around 13 October 2020)
  • Testnet is past the block reorg limit for the first halving (that is, 1_116_102 or later)

Software and Data Requirements:

  • A syncronised zcashd testnet instance
  • The zcash-cli RPC tool

Tasks:

@teor2345 teor2345 added E-easy A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement labels Sep 28, 2020
@teor2345
Copy link
Contributor Author

This seems like a quick and easy way to improve our test coverage.

I don't know if any of our current code depends on anything that happens after the first halving, but adding these test vectors is one way to be sure.

@teor2345 teor2345 self-assigned this Nov 12, 2020
@teor2345 teor2345 added the S-needs-triage Status: A bug report needs triage label Dec 4, 2020
@mpguerra mpguerra removed this from the v1.0.0-alpha.1 milestone Jan 11, 2021
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Feb 2, 2021
@teor2345 teor2345 added this to the 2021 Sprint 6 milestone Mar 15, 2021
@teor2345
Copy link
Contributor Author

Since we've shifted the mandatory checkpoint to Canopy in #1898, we should probably add these test vectors soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants