panic in NonFinalizedState::commit_block before Canopy
#1909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
reviewed
Mar 15, 2021
We try to do mainnet and testnet tests whenever we can, because it gets us better coverage. |
Co-authored-by: teor <teor@riseup.net>
teor2345
approved these changes
Mar 17, 2021
23 tasks
dconnolly
added a commit
that referenced
this pull request
Mar 23, 2021
Zebra's latest alpha checkpoints on Canopy activation, continues our work on NU5, and fixes a security issue. Some notable changes include: ## Added - Log address book metrics when PeerSet or CandidateSet don't have many peers (#1906) - Document test coverage workflow (#1919) - Add a final job to CI, so we can easily require all the CI jobs to pass (#1927) ## Changed - Zebra has moved its mandatory checkpoint from Sapling to Canopy (#1898, #1926) - This is a breaking change for users that depend on the exact height of the mandatory checkpoint. ## Fixed - tower-batch: wake waiting workers on close to avoid hangs (#1908) - Assert that pre-Canopy blocks use checkpointing (#1909) - Fix CI disk space usage by disabling incremental compilation in coverage builds (#1923) ## Security - Stop relying on unchecked length fields when preallocating vectors (#1925)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Panic for blocks before canopy is required for
NonFinalizedState::commit_blockafter #1898 gets merged.More info at #1903
Blocked on #1099
Solution
In this PR we add the panic however test cases will fail as we need mainnet blocks after Canopy. #1099
If we decide to also make this tests for the testnet then we also need #1104
If we only test mainnet we just need to replace the test vector numbers in the failing tests by the new ones. If we also do the testnet then a bit of the logic will need to change.
Related Tickets
Closes #1903
Review
This is in draft state until unblocked. No review needed yet.