-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document coverage workflow #1919
Conversation
I also see a failed attempt to upload to Should we disable that step for now?
|
sounds good. I just can't get over how hilarious it is that the feature broke in the PR I was documenting it from, even though its been working for months and this PR doesn't change it at all. What a world. |
The latest coverage builds with CARGO_INCREMENTAL: 0 are not showing upload errors so I think this was a spurious error. We should rebase this branch to pick up that coverage.yml change. |
2aa0789
to
cb596eb
Compare
Zebra's latest alpha checkpoints on Canopy activation, continues our work on NU5, and fixes a security issue. Some notable changes include: ## Added - Log address book metrics when PeerSet or CandidateSet don't have many peers (#1906) - Document test coverage workflow (#1919) - Add a final job to CI, so we can easily require all the CI jobs to pass (#1927) ## Changed - Zebra has moved its mandatory checkpoint from Sapling to Canopy (#1898, #1926) - This is a breaking change for users that depend on the exact height of the mandatory checkpoint. ## Fixed - tower-batch: wake waiting workers on close to avoid hangs (#1908) - Assert that pre-Canopy blocks use checkpointing (#1909) - Fix CI disk space usage by disabling incremental compilation in coverage builds (#1923) ## Security - Stop relying on unchecked length fields when preallocating vectors (#1925)
Motivation
I setup source based coverage reports for zebra a while ago but they're not very obvious so I'm documenting how to access them before I leave so they don't get forgotten.
Solution
The code in this pull request has:
Review
Related Issues
Follow Up Work