Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document coverage workflow #1919

Merged
merged 1 commit into from
Mar 20, 2021
Merged

document coverage workflow #1919

merged 1 commit into from
Mar 20, 2021

Conversation

yaahc
Copy link
Contributor

@yaahc yaahc commented Mar 18, 2021

Motivation

I setup source based coverage reports for zebra a while ago but they're not very obvious so I'm documenting how to access them before I leave so they don't get forgotten.

Solution

The code in this pull request has:

  • Documentation Comments

Review

Related Issues

Follow Up Work

@zfnd-bot zfnd-bot bot assigned yaahc Mar 18, 2021
@yaahc yaahc requested a review from a team March 18, 2021 17:52
@teor2345
Copy link
Contributor

I also see a failed attempt to upload to codecov.io in CI, due to missing API(?) tokens.

Should we disable that step for now?

==> Uploading reports
    url: https://codecov.io
    query: branch=coverage-no-incremental&commit=416cdabe60dc015db15c6a9ecd228a88e411d20f&build=666374397&build_url=http%3A%2F%2Fgithub.com%2FZcashFoundation%2Fzebra%2Factions%2Fruns%2F666374397&name=&tag=&slug=ZcashFoundation%2Fzebra&service=github-actions&flags=&pr=1923&job=CI&cmd_args=n,F,Q,C
->  Pinging Codecov
https://codecov.io/upload/v4?package=github-action-20210309-2b87ace&token=secret&branch=coverage-no-incremental&commit=416cdabe60dc015db15c6a9ecd228a88e411d20f&build=666374397&build_url=http%3A%2F%2Fgithub.com%2FZcashFoundation%2Fzebra%2Factions%2Fruns%2F666374397&name=&tag=&slug=ZcashFoundation%2Fzebra&service=github-actions&flags=&pr=1923&job=CI&cmd_args=n,F,Q,C
{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
404
==> Uploading to Codecov
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 3218k  100   171  100 3218k   1075  19.7M --:--:-- --:--:-- --:--:-- 19.7M
    {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

@yaahc
Copy link
Contributor Author

yaahc commented Mar 19, 2021

Should we disable that step for now?

sounds good. I just can't get over how hilarious it is that the feature broke in the PR I was documenting it from, even though its been working for months and this PR doesn't change it at all. What a world.

@dconnolly
Copy link
Contributor

I also see a failed attempt to upload to codecov.io in CI, due to missing API(?) tokens.

Should we disable that step for now?

==> Uploading reports
    url: https://codecov.io
    query: branch=coverage-no-incremental&commit=416cdabe60dc015db15c6a9ecd228a88e411d20f&build=666374397&build_url=http%3A%2F%2Fgithub.com%2FZcashFoundation%2Fzebra%2Factions%2Fruns%2F666374397&name=&tag=&slug=ZcashFoundation%2Fzebra&service=github-actions&flags=&pr=1923&job=CI&cmd_args=n,F,Q,C
->  Pinging Codecov
https://codecov.io/upload/v4?package=github-action-20210309-2b87ace&token=secret&branch=coverage-no-incremental&commit=416cdabe60dc015db15c6a9ecd228a88e411d20f&build=666374397&build_url=http%3A%2F%2Fgithub.com%2FZcashFoundation%2Fzebra%2Factions%2Fruns%2F666374397&name=&tag=&slug=ZcashFoundation%2Fzebra&service=github-actions&flags=&pr=1923&job=CI&cmd_args=n,F,Q,C
{'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}
404
==> Uploading to Codecov
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed

  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100 3218k  100   171  100 3218k   1075  19.7M --:--:-- --:--:-- --:--:-- 19.7M
    {'detail': ErrorDetail(string='Unable to locate build via Github Actions API. Please upload with the Codecov repository upload token to resolve issue.', code='not_found')}

The latest coverage builds with CARGO_INCREMENTAL: 0 are not showing upload errors so I think this was a spurious error.

We should rebase this branch to pick up that coverage.yml change.

@yaahc yaahc force-pushed the jane/coverage-docs branch from 2aa0789 to cb596eb Compare March 19, 2021 22:46
@dconnolly dconnolly merged commit b835a04 into main Mar 20, 2021
@dconnolly dconnolly deleted the jane/coverage-docs branch March 20, 2021 18:59
@dconnolly dconnolly added A-infrastructure Area: Infrastructure changes A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code A-docs Area: Documentation labels Mar 20, 2021
@dconnolly dconnolly added this to the 2021 Sprint 5 milestone Mar 20, 2021
@dconnolly dconnolly mentioned this pull request Mar 23, 2021
23 tasks
dconnolly added a commit that referenced this pull request Mar 23, 2021
Zebra's latest alpha checkpoints on Canopy activation, continues our work on NU5, and fixes a security issue.

Some notable changes include:

## Added
- Log address book metrics when PeerSet or CandidateSet don't have many peers (#1906)
- Document test coverage workflow (#1919)
- Add a final job to CI, so we can easily require all the CI jobs to pass (#1927)

## Changed
- Zebra has moved its mandatory checkpoint from Sapling to Canopy (#1898, #1926)
  - This is a breaking change for users that depend on the exact height of the mandatory checkpoint.

## Fixed
- tower-batch: wake waiting workers on close to avoid hangs (#1908)
- Assert that pre-Canopy blocks use checkpointing (#1909)
- Fix CI disk space usage by disabling incremental compilation in coverage builds (#1923)

## Security
- Stop relying on unchecked length fields when preallocating vectors (#1925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-docs Area: Documentation A-infrastructure Area: Infrastructure changes A-rust Area: Updates to Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants