Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic on pre-Canopy blocks in NonFinalizedState::commit_block #1903

Closed
1 task
teor2345 opened this issue Mar 15, 2021 · 0 comments · Fixed by #1909
Closed
1 task

Panic on pre-Canopy blocks in NonFinalizedState::commit_block #1903

teor2345 opened this issue Mar 15, 2021 · 0 comments · Fixed by #1909
Assignees
@oxarbitrage
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-security Category: Security issues I-invalid-data Zebra relies on invalid or untrusted data, or sends invalid data I-usability Zebra is hard to understand or use NU-5 Network Upgrade: NU5 specific tasks
Milestone
2021 Sprint 5

Comments

@teor2345
Copy link
Contributor

Is your feature request related to a problem? Please describe.

After #1898, our state design RFC requires that NonFinalizedState::commit_block panics if the block is a pre-Canopy block.

Before #1898, this panic was implicit in the transaction validation. But now that we're checkpointing on Canopy, we need an explicit panic.

Describe the solution you'd like

  • At the start of NonFinalizedState::commit_block, panic if the block height is less than the Canopy activation height for the current network

Describe alternatives you've considered

Don't panic
@teor2345 teor2345 added C-enhancement Category: This is an improvement S-needs-triage Status: A bug report needs triage labels Mar 15, 2021
@teor2345 teor2345 added this to the 2021 Sprint 5 milestone Mar 15, 2021
@teor2345 teor2345 added A-rust Area: Updates to Rust code C-bug Category: This is a bug C-security Category: Security issues I-invalid-data Zebra relies on invalid or untrusted data, or sends invalid data I-usability Zebra is hard to understand or use NU-5 Network Upgrade: NU5 specific tasks P-Medium and removed C-enhancement Category: This is an improvement labels Mar 15, 2021
@teor2345 teor2345 mentioned this issue Mar 15, 2021
Merged
@oxarbitrage oxarbitrage mentioned this issue Mar 15, 2021
Merged
@teor2345 teor2345 mentioned this issue Mar 16, 2021
Merged
2 tasks
@mpguerra mpguerra removed the S-needs-triage Status: A bug report needs triage label Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oxarbitrage oxarbitrage

Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-security Category: Security issues I-invalid-data Zebra relies on invalid or untrusted data, or sends invalid data I-usability Zebra is hard to understand or use NU-5 Network Upgrade: NU5 specific tasks
Projects
None yet
Milestone
2021 Sprint 5
Development

Successfully merging a pull request may close this issue.

panic in NonFinalizedState::commit_block before Canopy oxarbitrage/zebra
3 participants
@mpguerra @teor2345 @oxarbitrage