Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Canopy and Post-Halving test vectors #1910

Merged
merged 2 commits into from
Mar 16, 2021
Merged

Add Canopy and Post-Halving test vectors #1910

merged 2 commits into from
Mar 16, 2021

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 16, 2021 •
edited
Loading

Motivation

We want to test Post-Canopy blocks on mainnet, and Post-Halving blocks on testnet.

Solution

  • Add post-canopy mainnet block test vectors
  • Add post-halving testnet block test vectors

The code in this pull request has:

  • Documentation Comments
  • Existing Unit Tests and Property Tests

Review

@oxarbitrage wants this change for #1903

Review Note

GitHub displays zebra-test/src/vectors/block-main-1-046-401.bin as an empty file in the unified diff view, but it actually contains 72 kB of binary data.

Related Issues

Closes #1099
Closes #1104

Follow Up Work

We'll need to do something similar for NU5.

@teor2345 teor2345 added A-rust Area: Updates to Rust code NU-4 Canopy Network Upgrade: Canopy specific tasks C-enhancement Category: This is an improvement P-Medium labels Mar 16, 2021
@teor2345 teor2345 requested a review from oxarbitrage March 16, 2021 01:35
@teor2345 teor2345 self-assigned this Mar 16, 2021
teor2345 added 2 commits March 16, 2021 11:37
@teor2345
Add Mainnet Canopy block test vectors
8877139 
Including one block that just happened to be 72 kB, in binary format.
@teor2345
Add Testnet Post-Halving block test vectors
7a8e9ed
@teor2345
Copy link
Contributor Author

@oxarbitrage just a note for your review:

GitHub displays zebra-test/src/vectors/block-main-1-046-401.bin as an empty file in the unified diff view, but it actually contains 72 kB of binary data.

@teor2345 teor2345 force-pushed the canopy-test-vectors branch from 7a66fc7 to 7a8e9ed Compare March 16, 2021 05:35
oxarbitrage
oxarbitrage approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @teor2345 , looks great.

dconnolly
dconnolly approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉📦🔗

@dconnolly dconnolly merged commit 9c0c2f0 into ZcashFoundation:main Mar 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

@oxarbitrage oxarbitrage oxarbitrage approved these changes

Assignees

@teor2345 teor2345

Labels
A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement NU-4 Canopy Network Upgrade: Canopy specific tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Testnet Post-Halving Block Test Vectors Add Mainnet Canopy Block Test Vectors
3 participants
@teor2345 @dconnolly @oxarbitrage