You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
teor2345
changed the title
Use ServiceExt::oneshot in zebra-consensus
Adjust the zebra-consensus Buffer size, and document Buffer hang risks
Feb 15, 2021
teor2345
changed the title
Adjust the zebra-consensus Buffer size, and document Buffer hang risks
Adjust zebra-consensus Buffer sizes, and document Buffer hang risks
Feb 15, 2021
Is your feature request related to a problem? Please describe.
zebra-consensus
uses a lot ofBuffer
ed andBatch
ed services, but we haven't really checked that their bounds are high enough.The underlying issues are:
Buffer
orBatch
with a small bound, Zebra can hang.Buffer
s orBatch
es with small bounds can also limit concurrency, particularly if the underlying service does a lot of work in itscall
.Describe the solution you'd like
Buffer
andBatch
bounds acrosszebra-consensus
Document the
Buffer
andBatch
constraints in:ChainVerifier
BlockVerifier
TransactionVerifier
- 1 per transaction?CheckpointVerifier
transaction::Verifier
See #1593 for details.
Describe alternatives you've considered
Do nothing: the code might hang if future changes break the
poll_ready/call
invariants.Additional context
This issue was discovered during the review in #1593. It is a routine cleanup.
The text was updated successfully, but these errors were encountered: