Partly revert "Fix poll_ready usage in ChainVerifier" #1735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 0723ac5.
teor2345
commented
Feb 15, 2021
teor2345
commented
Feb 15, 2021
teor2345
commented
Feb 15, 2021
teor2345
commented
Feb 15, 2021
teor2345
commented
Feb 15, 2021
|
I think @yaahc should check this PR out as well. Turns out the revert is non-trivial. |
teor2345
commented
Feb 15, 2021
This was referenced Feb 15, 2021
teor2345
commented
Feb 15, 2021
|
The Windows CI failure should be fixed by #1736. |
2 tasks
teor2345
changed the title
teor2345
added
I-slow
|
It's possible that the small buffers fixed in this PR could hang |
|
Hmm seems like CI failed because cargo couldn't download crates. Retrying. |
18 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1700
This revert is ok, because the underlying bug in
tower::Bufferhas been fixed. See #1593 for details.But the code needs a few tweaks to avoid unlikely deadlocks.
The underlying services aren't directly buffered, but they do use some buffered services. We have open tickets for checking their buffer bounds (#1675), and dealing with backpressure more generally (#1618).