-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase the conflict acceptance test launch delay #1736
Conversation
Also rename the tests - the listener is for the Zcash protocol, but the state, metrics, and tracing are Zebra-specific.
Maybe the Windows CI is slow - I just saw a similar error in the tracing test at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should change zcash_listener_conflict()
to zebra_listener_conflict()
here as well.
Also, the comment should refer to increased time by metrics or tracing failures in the windows CI.
It's Zebra's Zcash network protocol listener port, which can conflict with zcashd's Zcash listener port. Unlike the rest of the ports, which are unique to Zebra. I'm happy to say zebra_zcash_listener_port, but the "zcash" is important here. |
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
I'm going to merge this now, because it's a CI fix, and the feedback was all applied. |
Motivation
The Windows CI failed the metrics_conflict test, because node1 opened its listener after node2:
https://github.com/ZcashFoundation/zebra/pull/1733/checks?check_run_id=1899814880#step:7:1584
Solution
Also rename the tests - the listener is for the Zcash protocol, but the state, metrics, and tracing are Zebra-specific.