Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the conflict acceptance test launch delay #1736

Merged
merged 3 commits into from
Feb 15, 2021
Merged

Conversation

teor2345
Copy link
Contributor

Motivation

The Windows CI failed the metrics_conflict test, because node1 opened its listener after node2:
https://github.com/ZcashFoundation/zebra/pull/1733/checks?check_run_id=1899814880#step:7:1584

Error: 
   0: Access is denied. (os error 5)

Unread Stderr:
   The application panicked (crashed).
   Message:  Opening metrics endpoint listener 127.0.0.1:49752 failed

   14: zebra_test::command::TestChild<tempdir::TempDir>::kill<tempdir::TempDir><unknown>
      at D:\a\zebra\zebra\zebra-test\src\command.rs:166
       164 │     pub fn kill(&mut self) -> Result<()> {
       165 │         /// SPANDOC: Killing child process
       166 >         self.child.kill().context_from(self)?;
       167 │ 
       168 │         Ok(())
  15: acceptance::check_config_conflict<tempdir::TempDir,tempdir::TempDir><unknown>
      at D:\a\zebra\zebra\zebrad\tests\acceptance.rs:1215
      1213 │     // Second node is terminated by panic, no need to kill.
      1214 │     std::thread::sleep(LAUNCH_DELAY);
      1215 >     node1.kill()?;

Solution

Also rename the tests - the listener is for the Zcash protocol, but the state, metrics, and tracing are Zebra-specific.

Also rename the tests - the listener is for the Zcash protocol,
but the state, metrics, and tracing are Zebra-specific.
@teor2345 teor2345 added C-bug Category: This is a bug A-rust Area: Updates to Rust code C-cleanup Category: This is a cleanup P-High labels Feb 15, 2021
@teor2345 teor2345 added this to the 2021 Sprint 3 milestone Feb 15, 2021
@teor2345 teor2345 self-assigned this Feb 15, 2021
@teor2345
Copy link
Contributor Author

teor2345 commented Feb 15, 2021

Maybe the Windows CI is slow - I just saw a similar error in the tracing test at:
https://github.com/ZcashFoundation/zebra/pull/1735/checks?check_run_id=1900870121

Copy link
Contributor

@oxarbitrage oxarbitrage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change zcash_listener_conflict() to zebra_listener_conflict() here as well.
Also, the comment should refer to increased time by metrics or tracing failures in the windows CI.

zebrad/tests/acceptance.rs Outdated Show resolved Hide resolved
@teor2345
Copy link
Contributor Author

I think we should change zcash_listener_conflict() to zebra_listener_conflict() here as well.

It's Zebra's Zcash network protocol listener port, which can conflict with zcashd's Zcash listener port. Unlike the rest of the ports, which are unique to Zebra. I'm happy to say zebra_zcash_listener_port, but the "zcash" is important here.

teor2345 and others added 2 commits February 16, 2021 05:51
Co-authored-by: Alfredo Garcia <oxarbitrage@gmail.com>
@teor2345
Copy link
Contributor Author

I'm going to merge this now, because it's a CI fix, and the feedback was all applied.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code C-bug Category: This is a bug C-cleanup Category: This is a cleanup
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants