Diagnostics for listener conflict CI failures #1766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
C-bug
dconnolly
previously approved these changes
Feb 17, 2021
This was referenced Feb 18, 2021
Log a "Trying..." message before each listener opens, to see if the delay is inside Zebra, or in the test harness or OS. Also report the configured and actual ports where possible, for better diagnostics.
teor2345
force-pushed
the
conflict-ci-diagnostics
branch
from
79d45e7
to
b7665a2
Compare
|
I rebased to drop unrelated commits. |
oxarbitrage
approved these changes
Feb 18, 2021
This was referenced Feb 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The
zebradlistener conflict tests are failing occasionally, and we're not quite sure why.See #1765 for details.
Solution
Review
These CI diagnostics are important, it will be hard to diagnose #1765 without them.
Related Issues
This PR adds diagnostics for #1765, but it doesn't fix it.
This is a follow up to #1736, which did not fix the CI failures. But it might have made them less frequent.
Follow Up Work
Actually fix the bug in #1765.