Actually use VerifyCheckpointError::CommitFinalized
#1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also: * use `ServiceExt::oneshot` in the checkpoint verifier * make some error messages more specific * clean up the `std::future`/`futures` imports
teor2345
force-pushed
the
commit-finalized-error
branch
from
9135bb3
to
addad71
Compare
oxarbitrage
approved these changes
Feb 8, 2021
dconnolly
pushed a commit
that referenced
this pull request
Feb 11, 2021
Also: * use `ServiceExt::oneshot` in the checkpoint verifier * make some error messages more specific * clean up the `std::future`/`futures` imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #1700 generates a warning that
VerifyCheckpointError::CommitFinalizedis unused.Solution
Actually use
VerifyCheckpointError::CommitFinalized.Also:
ServiceExt::oneshotin the checkpoint verifier (part of Adjust zebra-consensus Buffer sizes, and document Buffer hang risks #1675)std::future/futuresimportsThe code in this pull request has:
Review
@oxarbitrage can review this code - or anyone else.
We want to merge this PR before #1700 merges, to avoid those warnings.
Related Issues
Fixes part of ticket #1675.
Follow Up Work
Merge PR #1700.
Do the rest of the
ServiceExt::oneshotchanges in #1675.