Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add transparent address indexes to zebra-state #3150

Closed
6 tasks
mpguerra opened this issue Dec 3, 2021 · 2 comments
Closed
6 tasks

Add transparent address indexes to zebra-state #3150

mpguerra opened this issue Dec 3, 2021 · 2 comments
Assignees
Labels
A-rust Area: Updates to Rust code A-state Area: State / database changes lightwalletd any work associated with lightwalletd

Comments

@mpguerra
Copy link
Contributor

mpguerra commented Dec 3, 2021

Motivation

We want to answer transparent address RPCs quickly, so we need new indexes in the finalized state.

Designs

https://github.com/ZcashFoundation/zebra/blob/main/book/src/dev/rfcs/0005-state-updates.md#rocksdb-data-structures

Tasks

Implementation:

  • Add the new column family to the finalized state
  • Query the finalized index in the ReadRequest for ReadState, if it's ready
  • Increment the database version

Testing:

  • Update raw data snapshot tests
  • Add struct data snapshot tests

CI:

  • If you added new Rust module files, make sure the paths in the regenerate state job are up to date
@teor2345 teor2345 changed the title Add a transparent address -> transaction index to zebra-state Add a transparent address indexes to zebra-state Dec 6, 2021
@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement labels Feb 8, 2022
@ftm1000 ftm1000 added the S-needs-triage Status: A bug report needs triage label Feb 10, 2022
@ftm1000
Copy link

ftm1000 commented Feb 10, 2022

@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Feb 21, 2022
@teor2345 teor2345 changed the title Add a transparent address indexes to zebra-state Add transparent address indexes to zebra-state Mar 4, 2022
@ftm1000 ftm1000 added P-High 🔥 lightwalletd any work associated with lightwalletd and removed P-Medium ⚡ labels Mar 10, 2022
@ftm1000 ftm1000 added the S-blocked Status: Blocked on other tasks label Mar 21, 2022
@gustavovalverde gustavovalverde removed the A-devops Area: Pipelines, CI/CD and Dockerfiles label Mar 23, 2022
@teor2345 teor2345 self-assigned this Mar 23, 2022
@teor2345 teor2345 added A-state Area: State / database changes S-incomplete and removed S-blocked Status: Blocked on other tasks C-enhancement Category: This is an improvement labels Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rust Area: Updates to Rust code A-state Area: State / database changes lightwalletd any work associated with lightwalletd
Projects
None yet
Development

No branches or pull requests

4 participants