-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3. refactor(db): add disk serialization types for transactions #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-docs
Area: Documentation
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
P-Medium ⚡
A-state
Area: State / database changes
labels
Mar 4, 2022
teor2345
changed the title
refactor(db): add disk serialization types for transactions
3. refactor(db): add disk serialization types for transactions
Mar 4, 2022
Codecov Report
@@ Coverage Diff @@
## main #3741 +/- ##
==========================================
- Coverage 79.00% 78.74% -0.26%
==========================================
Files 292 292
Lines 33311 33379 +68
==========================================
- Hits 26317 26285 -32
- Misses 6994 7094 +100 |
dconnolly
previously approved these changes
Mar 4, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
teor2345
force-pushed
the
disk-format-split-modules
branch
from
March 4, 2022 22:43
f706967
to
58628f5
Compare
teor2345
force-pushed
the
db-transaction-types
branch
from
March 4, 2022 22:43
c2d735d
to
79feace
Compare
teor2345
force-pushed
the
disk-format-split-modules
branch
from
March 6, 2022 21:20
58628f5
to
bf9de1e
Compare
teor2345
force-pushed
the
db-transaction-types
branch
from
March 6, 2022 21:20
79feace
to
362879e
Compare
teor2345
force-pushed
the
disk-format-split-modules
branch
from
March 7, 2022 03:26
bf9de1e
to
0c84f37
Compare
teor2345
force-pushed
the
db-transaction-types
branch
from
March 7, 2022 03:26
362879e
to
d989daa
Compare
3 tasks
conradoplg
force-pushed
the
disk-format-split-modules
branch
from
March 7, 2022 14:53
0c84f37
to
0698e4b
Compare
teor2345
force-pushed
the
disk-format-split-modules
branch
from
March 8, 2022 02:56
0698e4b
to
0c5d549
Compare
teor2345
force-pushed
the
db-transaction-types
branch
from
March 8, 2022 02:56
d989daa
to
c4dc5cc
Compare
dconnolly
previously approved these changes
Mar 8, 2022
zebra-state/src/service/finalized_state/disk_format/shielded.rs
Outdated
Show resolved
Hide resolved
zebra-state/src/service/finalized_state/disk_format/tests/snapshot.rs
Outdated
Show resolved
Hide resolved
This changes the names of some snapshot types, but doesn't change any data.
This keeps the same serialization, to avoid changing the database version.
teor2345
force-pushed
the
db-transaction-types
branch
from
March 8, 2022 20:55
c4dc5cc
to
b8e96c0
Compare
upbqdn
approved these changes
Mar 8, 2022
This was referenced Mar 8, 2022
40 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-docs
Area: Documentation
A-rust
Area: Updates to Rust code
A-state
Area: State / database changes
C-enhancement
Category: This is an improvement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want to:
To do that, we need to have serialization-specific types for transactions and transparent outputs. And we want to remove duplicate code for height, transaction, and transparent serialization.
Designs
RocksDB section of the state RFC:
https://github.com/ZcashFoundation/zebra/blob/lightwalletd-state-rfc-fix/book/src/dev/rfcs/0005-state-updates.md#rocksdb-data-structures
Some of these types are renamed in this PR, for consistency.
Solution
Code changes:
The disk serialization format is the same, but some of the type names have changed. (These names don't get serialized.)
RFC updates:
Review
This PR is based on #3717, GitHub and Mergify should automatically handle the rebase and merge.
Reviewer Checklist
Follow Up Work