Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getrawmempool JSON-RPC method #3160

Closed
Tracked by #3134
teor2345 opened this issue Dec 6, 2021 · 1 comment · Fixed by #3851
Closed
Tracked by #3134

getrawmempool JSON-RPC method #3160

teor2345 opened this issue Dec 6, 2021 · 1 comment · Fixed by #3851
Assignees
Labels
lightwalletd any work associated with lightwalletd

Comments

@teor2345
Copy link
Contributor

teor2345 commented Dec 6, 2021

Motivation

lightwalletd uses the getrawmempool JSON-RPC method.

Assumptions

lightwalletd doesn't need witnessed mempool transaction IDs for Orchard (UnminedTxId).
https://discord.com/channels/809218587167293450/809250822579028008/943326658042163270

Required Fields

The method is documented here: https://zcash.github.io/rpc/getrawmempool.html

lightwalletd always uses the no-argument format: https://github.com/zcash/lightwalletd/blob/master/common/mempool.go#L95

And only these fields are used by lightwalletd: https://github.com/zcash/lightwalletd/blob/master/common/mempool.go#L106

Response:

[                     (json array of string)
  "transactionid"     (string) The transaction id - this is a TXID, not a WTXID
  ,...
]

Tasks

  • Implement the RPC method
  • Add RPC acceptance tests to CI
  • Test that the RPC method works with lightwalletd

API Reference

We plan to use jsonrpc_core with:

Example Code

Here are examples of:

@ftm1000 ftm1000 added the S-needs-triage Status: A bug report needs triage label Feb 10, 2022
@ftm1000
Copy link

ftm1000 commented Feb 10, 2022

@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Feb 18, 2022
@oxarbitrage oxarbitrage self-assigned this Mar 7, 2022
@mergify mergify bot closed this as completed in #3851 Mar 12, 2022
@ftm1000 ftm1000 added the lightwalletd any work associated with lightwalletd label Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants