Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lightwalletd): wait for successful block ingestion in integration tests #3824

Merged
merged 3 commits into from
Mar 12, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Mar 9, 2022

Motivation

lightwalletd can now ingest blocks from Zebra, so we should wait for the first ingestion in the integration tests.

Solution

Review

Anyone can review this PR, it doesn't actually block any work.

This PR is based on PR #3707 + main, it will need a manual rebase.

Reviewer Checklist

  • Tests for expected behaviour

Follow Up Work

The next integration RPC is:

@teor2345 teor2345 added C-enhancement Category: This is an improvement P-Medium ⚡ C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces labels Mar 9, 2022
@teor2345 teor2345 self-assigned this Mar 9, 2022
@teor2345 teor2345 requested review from a team as code owners March 9, 2022 23:26
@teor2345 teor2345 requested review from dconnolly and removed request for a team March 9, 2022 23:26
@teor2345 teor2345 changed the base branch from issue3144 to issue3144-main March 9, 2022 23:26
@teor2345 teor2345 removed the request for review from a team March 9, 2022 23:27
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

Merging #3824 (9ed45d9) into main (1f176d9) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3824      +/-   ##
==========================================
+ Coverage   78.82%   78.88%   +0.06%     
==========================================
  Files         292      292              
  Lines       33560    33571      +11     
==========================================
+ Hits        26454    26484      +30     
+ Misses       7106     7087      -19     

@teor2345 teor2345 force-pushed the lw-integration-block branch from d38063a to c364034 Compare March 10, 2022 02:28
@teor2345 teor2345 requested a review from a team as a code owner March 10, 2022 02:28
@teor2345 teor2345 changed the base branch from issue3144-main to main March 10, 2022 02:28
zebrad/tests/acceptance.rs Outdated Show resolved Hide resolved
@teor2345 teor2345 removed the request for review from a team March 10, 2022 04:16
mergify bot added a commit that referenced this pull request Mar 11, 2022
@mergify mergify bot merged commit ebecfd0 into main Mar 12, 2022
@mergify mergify bot deleted the lw-integration-block branch March 12, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-enhancement Category: This is an improvement C-testing Category: These are tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants