-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(rpc): implement getrawmempool
RPC method
#3851
Conversation
Ensure the returned type is serialized as an array of hexadecimal strings.
Test it with random sets of transaction IDs.
Run `rustfmt` inside the `proptest!` block.
By the lightwalletd integration tests logs it seems the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed some commits with the suggestions, but feel free to revert or discard them if you want to do it differently :)
Codecov Report
@@ Coverage Diff @@
## main #3851 +/- ##
==========================================
- Coverage 78.82% 78.74% -0.08%
==========================================
Files 295 295
Lines 33764 33788 +24
==========================================
- Hits 26613 26606 -7
- Misses 7151 7182 +31 |
getrawtransaction
RPC methodgetrawmempool
RPC method
Motivation
Will close #3160 eventually when done.
Solution
Implement
getrawmempool
Review
@jvff already is working with me in this so will be nice to get a review from someone else.
Reviewer Checklist