Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker tests for default config and $ZEBRA_CONF_PATH #5168

Closed
teor2345 opened this issue Sep 15, 2022 · 4 comments · Fixed by #5968
Closed

Add Docker tests for default config and $ZEBRA_CONF_PATH #5168

teor2345 opened this issue Sep 15, 2022 · 4 comments · Fixed by #5968
Assignees
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-testing Category: These are tests

Comments

@teor2345
Copy link
Contributor

teor2345 commented Sep 15, 2022

Motivation

We want to test that our Docker build scripts configure Zebra correctly:

  • check that $ZEBRA_CONF_PATH works
  • make sure the default Docker config works with the latest Zebra version

Suggested Solution

Here's one possible test script:

# make sure Zebra runs with the default docker config
docker run ... | grep --max-count=1 'estimated progress to chain tip.*BeforeOverwinter'
docker stop ...

# make sure Zebra runs with a custom docker config
TODO: copy the file into docker?
export ZEBRA_CONF_PATH=`zebra/zebrad/tests/common/configs/v1.0.0-rc.2.toml`
docker run ... | grep --max-count=1 'v1.0.0-rc.2.toml'
docker stop ...

Related Work

Originally posted by @teor2345 in #5163 (comment)

The test script depends on PR #5733 merging.

@teor2345 teor2345 added A-devops Area: Pipelines, CI/CD and Dockerfiles P-Medium ⚡ C-testing Category: These are tests labels Sep 15, 2022
@mpguerra mpguerra moved this to 🆕 New in Zebra Sep 22, 2022
@mpguerra mpguerra added this to Zebra Sep 22, 2022
@teor2345 teor2345 added the A-rust Area: Updates to Rust code label Sep 27, 2022
@mpguerra
Copy link
Contributor

removing this one from the release candidate epic

@teor2345
Copy link
Contributor Author

This isn't causing any problems for us right now, but we should test this new docker feature soon. (In the next sprint is ok.)

@teor2345
Copy link
Contributor Author

I added some more details to this ticket, and a possible test script.

@teor2345
Copy link
Contributor Author

teor2345 commented Dec 5, 2022

@mpguerra I moved this ticket out of this sprint, because some devops tasks were still open from last sprint.

But feel free to move it back in!

@mpguerra mpguerra moved this from 🆕 New to 📋 Sprint Backlog in Zebra Jan 19, 2023
@mpguerra mpguerra moved this from 📋 Sprint Backlog to 🏗 In progress in Zebra Jan 19, 2023
@mergify mergify bot closed this as completed in #5968 Jan 23, 2023
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Zebra Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-testing Category: These are tests
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants