Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(log): Log loaded config path when Zebra starts up #5733

Merged
merged 4 commits into from
Nov 30, 2022
Merged

Conversation

teor2345
Copy link
Contributor

Motivation

  1. We need to check the correct Docker config is loaded in ticket Add Docker tests for default config and $ZEBRA_CONF_PATH #5168
  2. Users need to know what config they are loading so they can debug config issues

Solution

  • Log the config path and fields for all Zebra server commands
  • Remove a duplicate config fields log for the start command

Review

Anyone can review this routine PR.

Reviewer Checklist

  • Will the PR name make sense to users?
    • Does it need extra CHANGELOG info? (new features, breaking changes, large changes)
  • Are the PR labels correct?
  • Does the code do what the ticket and PR says?
  • How do you know it works? Does it have tests?

Follow Up Work

Testing in #5168

@teor2345 teor2345 added A-rust Area: Updates to Rust code P-Medium ⚡ I-usability Zebra is hard to understand or use A-diagnostics Area: Diagnosing issues or monitoring performance C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG labels Nov 28, 2022
@teor2345 teor2345 requested a review from a team as a code owner November 28, 2022 22:23
@teor2345 teor2345 self-assigned this Nov 28, 2022
@teor2345 teor2345 requested review from arya2 and removed request for a team November 28, 2022 22:23
@github-actions github-actions bot added the C-enhancement Category: This is an improvement label Nov 28, 2022
@teor2345

This comment was marked as resolved.

Copy link
Contributor

@arya2 arya2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #5733 (5329498) into main (eb66f4b) will increase coverage by 0.01%.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5733      +/-   ##
==========================================
+ Coverage   78.78%   78.80%   +0.01%     
==========================================
  Files         306      306              
  Lines       38552    38552              
==========================================
+ Hits        30375    30379       +4     
+ Misses       8177     8173       -4     

mergify bot added a commit that referenced this pull request Nov 29, 2022
@teor2345
Copy link
Contributor Author

Merge queue failed due to #5384

@teor2345
Copy link
Contributor Author

@Mergifyio refresh

@mergify
Copy link
Contributor

mergify bot commented Nov 29, 2022

refresh

✅ Pull request refreshed

mergify bot added a commit that referenced this pull request Nov 30, 2022
@mergify mergify bot merged commit 0ec502b into main Nov 30, 2022
@mergify mergify bot deleted the log-config-path branch November 30, 2022 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-diagnostics Area: Diagnosing issues or monitoring performance A-rust Area: Updates to Rust code C-enhancement Category: This is an improvement C-testing Category: These are tests C-trivial Category: A trivial change that is not worth mentioning in the CHANGELOG I-usability Zebra is hard to understand or use
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants