-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(log): Log loaded config path when Zebra starts up #5733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
A-rust
Area: Updates to Rust code
P-Medium ⚡
I-usability
Zebra is hard to understand or use
A-diagnostics
Area: Diagnosing issues or monitoring performance
C-testing
Category: These are tests
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
labels
Nov 28, 2022
This comment was marked as resolved.
This comment was marked as resolved.
arya2
approved these changes
Nov 28, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #5733 +/- ##
==========================================
+ Coverage 78.78% 78.80% +0.01%
==========================================
Files 306 306
Lines 38552 38552
==========================================
+ Hits 30375 30379 +4
+ Misses 8177 8173 -4 |
Merge queue failed due to #5384 |
@Mergifyio refresh |
✅ Pull request refreshed |
gustavovalverde
approved these changes
Nov 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Diagnosing issues or monitoring performance
A-rust
Area: Updates to Rust code
C-enhancement
Category: This is an improvement
C-testing
Category: These are tests
C-trivial
Category: A trivial change that is not worth mentioning in the CHANGELOG
I-usability
Zebra is hard to understand or use
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Solution
Review
Anyone can review this routine PR.
Reviewer Checklist
Follow Up Work
Testing in #5168