Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor tests to use is_mainnet() to look up test vectors using new functions in zebra-test #8325

Closed
Tracked by #7845
arya2 opened this issue Feb 26, 2024 · 0 comments · Fixed by #8295
Closed
Tracked by #7845

Refactor tests to use is_mainnet() to look up test vectors using new functions in zebra-test #8325

arya2 opened this issue Feb 26, 2024 · 0 comments · Fixed by #8295
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-testing Category: These are tests good first issue

Comments

@arya2
Copy link
Contributor

arya2 commented Feb 26, 2024 •
edited
Loading

Motivation

We want to add an is_mainnet() method to Network and refactor tests to use it instead of matching on Testnet to minimize the changes in following PRs that add parameters to the Testnet variant.

See step 1 in #7967 (comment)
@arya2 arya2 added A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes NU-6 Network Upgrade: NU6 specific tasks C-testing Category: These are tests C-feature Category: New features labels Feb 26, 2024
@arya2 arya2 mentioned this issue Feb 26, 2024
Closed
14 tasks
@github-project-automation github-project-automation bot moved this to New in Zebra Feb 26, 2024
@arya2 arya2 added C-enhancement Category: This is an improvement and removed C-feature Category: New features labels Feb 26, 2024
@arya2 arya2 mentioned this issue Feb 26, 2024
Closed
@AloeareV AloeareV mentioned this issue Feb 26, 2024
Merged
9 tasks
@zancas zancas mentioned this issue Feb 29, 2024
Draft
@mpguerra mpguerra moved this from New to Review/QA in Zebra Mar 5, 2024
@github-project-automation github-project-automation bot moved this from Review/QA to Done in Zebra Mar 5, 2024
@mpguerra mpguerra added this to the Regtest milestone Mar 6, 2024
@mpguerra mpguerra removed the NU-6 Network Upgrade: NU6 specific tasks label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-consensus Area: Consensus rule updates A-network Area: Network protocol updates or fixes C-enhancement Category: This is an improvement C-testing Category: These are tests good first issue
Projects
Zebra
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change(tests): Remove Matches on Network From Tests idky137/zebra
2 participants
@mpguerra @arya2