-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an empty NetworkParameters
struct to Network::Testnet
#7968
Comments
If I'm going to implement this, is the intent here to replace the |
Squashed from multiple commits to enable partial rebase
We want to do this to minimize the changes in the following PRs where the We decided PR #7924 was too large to test or review accurately, and because this is a high-risk area of the code, we want to divide the changes across multiple PRs, where each PR adds one configurable parameter and We also discussed #1135 around the time that #7924 was opened, and decided to add any configurable parameters to the |
NetworkParameters
struct to Network::Testnet
TestnetParameters
struct to Network::Testnet
I split the "Multiple PRs" section of this issue into a separate issues in #7845. |
TestnetParameters
struct to Network::Testnet
NetworkParameters
struct to Network::Testnet
Squashed from multiple commits to enable partial rebase
…es to `Network` methods (#8340) * begin refactor suggested as "step 2": #7968 (comment) Squashed from multiple commits to enable partial rebase * break out more little traits * add activation implementation leveraging From<Network> for lrz::cons:: * for transfer of ownership I cannot return a type that's owned by the method * hrp_sapling_extended_full_viewing_key * complete implementation of interface of Parameters on Network reuse Parameters on zcash Network where possible * move doc-comments to trait declarations (from impls) * Simplify/complete Parameters impl for Network * Add checkpoint_list method, move documentation, etc * move last match network to inside network method * add back comment * use zcash_address for parameter types in zebra-chain * use inherent methods instead of big parameters passthrough * revert to implementation of From on zcash_primitives::..::Network vs &zcash_prim... * move match * add test to block maximum time rule * update changelog * finish porting target_difficutly_limit * remove obscelete code comment * revert non-functional change * finish migrating target_difficulty_limit, checkpoint_list * update changelog --------- Co-authored-by: Hazel OHearn <gygaxis@zingolabs.org>
Motivation
Zebra currently hard-codes some consensus parameters that may need to be changed for testing.
Depends-On: #8325, #8326
Possible Design
TestnetParameters
struct inNetwork::Testnet
Network::new_testnet()
method that returnsNetwork::Testnet { ..default_testnet_params }
Testnet
in tests withNetwork::new_testnet()
Example (with fields that shouldn't be added yet):
The text was updated successfully, but these errors were encountered: