-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(tests): Remove Matches on Network From Tests #8295
Conversation
Thank you for the PR! We will review and discuss as a team to decide how to proceed with this one. |
We're following the steps here #7968 as a starting point |
@AloeareV this #7967 (comment) is more detailed than #7968. |
Currently implements the first point in #7968. However new vector fetching functionality has been implemented as methods on Network, held in |
changed scope of PR to ease merging. |
fixes #8325, thanks for issuing this! |
…tests.rs, needs refactoring
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for these changes!!
The first 13 commits are looking good and ready to merge once CI passes.
The only change I think is needed is removing the serialization error variant or hiding it behind #[cfg(test)]
.
If there's interest in implementing #8326 or #7968, please do these in follow-up PRs so the changes are easy to test and review.
We want the Zebra team to implement the issues following #7968 in #7845 for adding parameters, because those changes may have far-reaching implications across the codebase, and we expect context and familiarity with the Zebra codebase will make it easier to implement those changes correctly.
Note: We just started a hack sprint, so reviews on those changes may be delayed until our next sprint.
… option and removed serialization error types as per requested changes in PR review
…st_transactions() and new zebra-grpc tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Motivation
We would like to implement regtest mode in zebrad to allow development to move away from relying on zcashd for testing. (https://forum.zcashcommunity.com/t/zingo-onward/43945/44)
As Per #7967 we have decided to implement this in multiple stages, to ease the process of merging code.
This PR completes point 1 in #7968.
Closes #8325.
PR Author Checklist
Check before marking the PR as ready for review:
For significant changes:
If a checkbox isn't relevant to the PR, mark it as done.
Solution
We have added a new set of methods for Network in Zebra-chain to remove the reliance on matching on the Network type and to move code fetching test vectors into a single file.
Testing
This PR effects tests in Zebra-Chain, Zebra-Consensus, Zebra-RPC, Zebra-GRPC, Zebra-Scan, Zebra-State and Zebrad.
Reviewer Checklist
Check before approving the PR:
PR blockers can be dealt with in new tickets or PRs.
And check the PR Author checklist is complete.