Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix minimum difficulty bugs #1256

Merged
merged 7 commits into from
Nov 12, 2020
Merged

Fix minimum difficulty bugs #1256

merged 7 commits into from
Nov 12, 2020

Commits on Nov 12, 2020

  1. Add a comment explaining the issues in ZIPs 205 and 208 

    And add the network to the difficulty filter error.
    @teor2345
    teor2345 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    35232a1 View commit details
    Browse the repository at this point in the history

  2. Refactor block target spacing into NetworkUpgrade methods 

    And add a method for the minimum difficulty time gap threshold.
    @teor2345
    teor2345 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    42bc1a6 View commit details
    Browse the repository at this point in the history

  3. Make ExpandedDifficulty Debug byte order match Hash 

    Bugfix on PR ZcashFoundation#1171.
    @teor2345
    teor2345 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    bff8cc1 View commit details
    Browse the repository at this point in the history

  4. Round-trip the PoWLimit through the compact representation 

    `zcashd` converts the PoWLimit into a compact representation before
using it to perform difficulty filter checks.

The Zcash specification converts to compact for the default difficulty
filter, but not for testnet minimum difficulty blocks. (ZIP 205 and
ZIP 208 don't specify this conversion either.) See ZcashFoundation#1277.
    @teor2345
    teor2345 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    c98714f View commit details
    Browse the repository at this point in the history

  5. Add minimum difficulty testnet block vectors

    @teor2345
    teor2345 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    7b8e76c View commit details
    Browse the repository at this point in the history

  6. Add tests for testnet minimum difficulty blocks

    @teor2345
    teor2345 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    e5a6eaf View commit details
    Browse the repository at this point in the history

  7. Update Cargo.lock 

    We need spandoc 0.2.1 to avoid a panic on empty blocks.
    @teor2345
    teor2345 committed Nov 12, 2020
    Configuration menu
    Copy the full SHA
    495685f View commit details
    Browse the repository at this point in the history