Add and use a function for mandatory checkpoint

[oxarbitrage]

Motivation

We want to refactor the mandatory checkpoint code into a function. If merged this will close #2305

Solution

Add a function into Network implementation. Use it.

Review

Anyone can review, is a minor cleanup change.

Reviewer Checklist

• Code implements Specs and Designs
• Tests for Expected Behaviour
• Tests for Errors

[teor2345]

The mandatory checkpoint is also used in the non-finalised state and tests, see PRs #1898 and #2235:

https://github.com/ZcashFoundation/zebra/pull/2235/files#diff-a2e205e7f47ebdd654a97d9a69c10fed917af8f6f6174e8cce994d5506eeded3R84

https://github.com/ZcashFoundation/zebra/pull/1898/files#diff-1dd2c3997d949843524447be1a8bd5a91543678197b10926b091d9de8b95c570R257

https://github.com/ZcashFoundation/zebra/pull/1898/files#diff-b33295e5bb25fffe92ba36f21922285a10a387c43838477a2b1bcee48e9b3a4cR851

After you've done all your changes, do a search for "Canopy.activation_height" to make sure you haven't missed any.

[oxarbitrage]

Apologies, the ticket was mentioning only #1846 so i missed those changes. Will fix.

[teor2345]

When you do the fix, can you also fix the clippy warnings as well?

[oxarbitrage]

When you do the fix, can you also fix the clippy warnings as well?

Sure, i think i missed that because since some time there are a lot of clippy warnings in the networking code and other unrelated code. I know is unrelated here but do we have a ticket for that ?

[oxarbitrage]

I also renamed a lot of acceptance tests (01a3438) that were syncing up to canopy in favour of syncing up to the mandatory checkpoint. I hope I didn't go too far.

[teor2345]

When you do the fix, can you also fix the clippy warnings as well?

Sure, i think i missed that because since some time there are a lot of clippy warnings in the networking code and other unrelated code. I know is unrelated here but do we have a ticket for that ?

There aren't any clippy warnings in Zebra's CI on the current main branch. Our CI runs clippy on every feature in every Zebra crate, including test code. PRs can't merge until they pass clippy.

We run clippy on:

• Linux
• rustc 1.52.1

Is your Rust install up to date? Sometimes warnings get fixed or removed from clippy.
Are your PRs based off an old version of the main branch?

[teor2345]

I also renamed a lot of acceptance tests (01a3438) that were syncing up to canopy in favour of syncing up to the mandatory checkpoint. I hope I didn't go too far.

This is great, feel free to update function names or docs, but they're not strictly required for this change.

[oxarbitrage]

In regards to clippy, it must be something local (https://gist.github.com/oxarbitrage/8d741c1231335e97c50a06fc9b94ca65). Will research more.

[teor2345]

In regards to clippy, it must be something local (https://gist.github.com/oxarbitrage/8d741c1231335e97c50a06fc9b94ca65). Will research more.

Your PR branch is up to date with our main branch.

What version of rustc are you using?

[oxarbitrage]

In regards to clippy, it must be something local (https://gist.github.com/oxarbitrage/8d741c1231335e97c50a06fc9b94ca65). Will research more.

Nevermind, i was in rust 1.51. Thanks.

[teor2345]

This looks good, we just need to update some feature names in the GitHub workflows as well.

[teor2345]

This change is ok, but it also needs an update to the GitHub workflows:
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/regenerate-stateful-test-disks.yml#L68
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/regenerate-stateful-test-disks.yml#L69
https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/test.yml#L72

If you're using fastmod, it skips hidden files and directories like .github by default.
You can use fastmod --hidden to change them as well, but you'll need fastmod version 0.4.2.

[teor2345]

Looks good, let's merge