Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Blocker: Stop skipping the cached sync tests in CI #2402

Merged
merged 1 commit into from
Jun 29, 2021

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented Jun 28, 2021

Motivation

PR #2314 changed the name of the cached state test functions in the code, but didn't change the test names in the CI workflow. This disabled the cached sync tests since Zebra 1.0.0-alpha.11.

Solution

  • Make sure Zebra's CI workflows are using the correct names for the cached state tests
    • using fastmod sync_past_canopy sync_past_mandatory_checkpoint .github zebra*
    • double-check rg sync_past_canopy .github zebra*

This PR re-enables the tests that should have caught bug #2401, so it might fail on main until PR #2404 is merged.

Review

@oxarbitrage can review this PR. It's blocking the next release, so it's urgent.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

We should work out how we can catch mistakes like this automatically, because it's easy to miss them during coding and review.

This is a bugfix on PR #2314, which changed the name of the test
function in the code, but didn't change the CI workflow.
@teor2345 teor2345 added C-bug Category: This is a bug A-devops Area: Pipelines, CI/CD and Dockerfiles P-High labels Jun 28, 2021
@teor2345 teor2345 requested a review from oxarbitrage June 28, 2021 06:22
@teor2345 teor2345 self-assigned this Jun 28, 2021
@teor2345 teor2345 marked this pull request as draft June 28, 2021 07:43
@teor2345 teor2345 marked this pull request as ready for review June 29, 2021 00:50
@teor2345 teor2345 added this to the 2021 Sprint 12 milestone Jun 29, 2021
@dconnolly
Copy link
Contributor

@teor2345 teor2345 merged commit 17e94bd into main Jun 29, 2021
@teor2345 teor2345 deleted the stop-skipping-cached-sync-test branch June 29, 2021 02:49
@teor2345
Copy link
Contributor Author

test sync_past_mandatory_checkpoint_mainnet ... ok

https://github.com/ZcashFoundation/zebra/runs/2937773217?check_suite_focus=true#step:6:2477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-bug Category: This is a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants