Release Blocker: Stop skipping the cached sync tests in CI #2402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #2314 changed the name of the cached state test functions in the code, but didn't change the test names in the CI workflow. This disabled the cached sync tests since Zebra
1.0.0-alpha.11
.Solution
fastmod sync_past_canopy sync_past_mandatory_checkpoint .github zebra*
rg sync_past_canopy .github zebra*
This PR re-enables the tests that should have caught bug #2401, so it might fail onmain
until PR #2404 is merged.Review
@oxarbitrage can review this PR. It's blocking the next release, so it's urgent.
Reviewer Checklist
Follow Up Work
We should work out how we can catch mistakes like this automatically, because it's easy to miss them during coding and review.