change(doc): Simplify the database design using prefix iterators #3916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
To avoid storing the transaction count for each block, we can use RocksDB prefix iterators.
API Reference
API Function:
https://docs.rs/rocksdb/latest/rocksdb/struct.DBWithThreadMode.html#method.prefix_iterator_cf
API Docs:
https://github.com/facebook/rocksdb/wiki/Prefix-Seek#why-prefix-seek
Designs
Iterate through every transaction for a height, rather than storing a transaction count.
Solution
Related changes:
Review
This is a low-priority design fix.
It would be good to have it merged by the database design review meeting later this week. (Wednesday evening UTC.)
Reviewer Checklist
Follow Up Work
Implement the design in: