Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lightwalletd full sync integration test #3511

Closed
Tracked by #3134
teor2345 opened this issue Feb 10, 2022 · 3 comments · Fixed by #4177
Closed
Tracked by #3134

Add lightwalletd full sync integration test #3511

teor2345 opened this issue Feb 10, 2022 · 3 comments · Fixed by #4177
Assignees
@teor2345
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-testing Category: These are tests lightwalletd any work associated with lightwalletd S-blocked Status: Blocked on other tasks

Comments

@teor2345
Copy link
Contributor

teor2345 commented Feb 10, 2022 •
edited by conradoplg
Loading

Motivation

Most lightwalletd RPC methods need a cached state to operate on.

We can construct these integration tests (modulo sending txs) with pre-synced/indexed state, so we don’t have to worry about mainnet/testnet weather.

Tasks

  • Attach a cached state disk to the lightwalletd integration tests
  • Add a test harness that opens the cached state, but doesn't haven't have any configured seed peers
  • Add a lightwalletd integration test for starts lightwalletd and waits for it to fully sync

Follow-Up Tasks
@teor2345 teor2345 added A-rust Area: Updates to Rust code A-devops Area: Pipelines, CI/CD and Dockerfiles S-needs-triage Status: A bug report needs triage C-testing Category: These are tests labels Feb 10, 2022
@teor2345 teor2345 mentioned this issue Feb 10, 2022
Closed
3 tasks
@teor2345
Copy link
Contributor Author

teor2345 commented Feb 10, 2022 •
edited
Loading

Hey team! Please add your planning poker estimate with ZenHub @conradoplg @dconnolly @oxarbitrage @jvff @upbqdn

@teor2345 teor2345 mentioned this issue Feb 10, 2022
Closed
33 tasks
@ftm1000 ftm1000 removed the S-needs-triage Status: A bug report needs triage label Feb 15, 2022
@dconnolly dconnolly changed the title Add cached state to lightwalletd integration tests Use cached state in lightwalletd integration tests Feb 15, 2022
@dconnolly dconnolly mentioned this issue Feb 15, 2022
Closed
2 tasks
@teor2345 teor2345 mentioned this issue Feb 16, 2022
Merged
3 tasks
@teor2345 teor2345 mentioned this issue Mar 16, 2022
Merged
3 tasks
@ftm1000 ftm1000 added the lightwalletd any work associated with lightwalletd label Mar 16, 2022
This was referenced Mar 17, 2022
Merged
Merged
Merged
Merged
Merged
@ftm1000 ftm1000 added the S-blocked Status: Blocked on other tasks label Mar 21, 2022
This was referenced Mar 23, 2022
Closed
Closed
@teor2345 teor2345 mentioned this issue Apr 5, 2022
Closed
@gustavovalverde gustavovalverde removed their assignment Apr 11, 2022
@teor2345 teor2345 assigned conradoplg and unassigned dconnolly Apr 19, 2022
@teor2345
Copy link
Contributor Author

We re-assigned this task to Conrado in yesterday's meeting.

@teor2345 teor2345 self-assigned this Apr 20, 2022
@conradoplg
Copy link
Collaborator

This ended up mutating into a different ticket, I changed the description and copied some of the old description into #4160

@conradoplg conradoplg changed the title Use cached state in lightwalletd integration tests Add lightwalletd full sync integration test Apr 21, 2022
This was referenced Apr 22, 2022
Merged
Closed
Merged
@mergify mergify bot closed this as completed in #4177 Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teor2345 teor2345

Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles A-rust Area: Updates to Rust code C-testing Category: These are tests lightwalletd any work associated with lightwalletd S-blocked Status: Blocked on other tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(rpc): Add Rust tests for lightwalletd sync from Zebra ZcashFoundation/zebra
5 participants
@conradoplg @dconnolly @teor2345 @gustavovalverde @ftm1000