-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
T2. add(test): add test API that checks process logs for failures #3899
Conversation
2af3008
to
b3df126
Compare
3c16b09
to
779a8f5
Compare
7cc555f
to
3e2cddf
Compare
3f6b1ff
to
2a7c108
Compare
2a7c108
to
3b7887a
Compare
3e2cddf
to
fcfc61e
Compare
Please rebase and fix conflicts when you get the time. Thanks! |
@Mergifyio update |
❌ Base branch update has failedmerge conflict between base and head |
@Mergifyio rebase |
❌ Base branch update has failedGit reported the following error:
err-code: A5E44 |
This reverts commit 2af3008.
It would be easy to disable these panics, and never realise.
And document some edge cases we don't handle yet
And check the actual command we're using to see if it errors.
fcfc61e
to
543db25
Compare
Done! The conflicts aren't real, they're just caused by squashing PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, very complete with a lot of testing so it should work pretty much as we expect.
Motivation
We want to check lightwalletd logs and Zebra logs for failures like:
But our testing framework makes it very hard to do that.
This PR adds an API to check test logs for failures, but it doesn't actually do those checks yet.
This is related to:
Designs
Add a set of failure regexes to each child process, and check each log line for those regexes. Panic if any failures are logged.
Make sure test processes are cleaned up correctly, so their logs are read and checked for failures.
Solution
Failure logs:
Reading process output:
Also document some edge cases, and some things we might want to fix later.
Review
This PR is not urgent.
It is based on PR #3892.
Reviewer Checklist
Follow Up Work