Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T3. add(test): check for failure messages in lightwalletd and Zebra logs #3903

Merged
merged 27 commits into from
Mar 23, 2022
Merged

T3. add(test): check for failure messages in lightwalletd and Zebra logs #3903

merged 27 commits into from
Mar 23, 2022

Conversation

teor2345
Copy link
Contributor

Motivation

We want to check lightwalletd logs and Zebra logs for failures like:

  • missing RPCs
  • RPC argument parse errors
  • RPC argument data errors
  • RPC response parse errors
  • RPC response data errors
  • other specific errors logged by lightwalletd

This PR checks lightwalletd and zebrad test logs for failure messages.

This is related to:

Solution

  • Add a list of failure messages for lightwalletd, zebrad, and any process
  • Check for them in the integration test logs

Review

This PR isn't urgent, but it might need changes when we add new RPCs.
(Or it might find bugs in new RPCs.)

This PR is based on PR #3899.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

Follow Up Work

Keep the failure lists up-to-date as we add new RPCs.

@teor2345 teor2345 added P-Medium ⚡ C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd labels Mar 18, 2022
@teor2345 teor2345 requested a review from a team as a code owner March 18, 2022 09:04
@teor2345 teor2345 self-assigned this Mar 18, 2022
@teor2345 teor2345 requested review from dconnolly and removed request for a team March 18, 2022 09:04
@teor2345 teor2345 changed the base branch from main to test-log-failure-regex March 18, 2022 09:04
@teor2345 teor2345 force-pushed the test-log-failure-regex branch from 7cc555f to 3e2cddf Compare March 18, 2022 09:09
@teor2345 teor2345 force-pushed the check-lightwalled-failures branch from 4f84779 to 5b56eb7 Compare March 18, 2022 09:09
teor2345 added 19 commits March 21, 2022 07:31
@teor2345
Make command test matching code accept generic regexes
5ce0dee 
And add generic conversions to regexes.
@teor2345
Document test command structs
2148dd4
@teor2345
Support matching multiple regexes internally in the test command
e5c42b8
@teor2345
Make it easier to call the generic regex methods
c4389fc
@teor2345
Add a missing API usage comment
a6d809b
@teor2345
Fix a potential hang in test child error reports
0241624
@teor2345
Revert Option<Child> process handling
3b7887a
@teor2345
Revert "Revert Option<Child> process handling"
d5c6d49 
This reverts commit 2af3008.
@teor2345
Add a set of failure regexes to test command output
78627d9
@teor2345
Allow debug-printing TestChild again
8301438
@teor2345
When the child is dropped, check any remaining output
bf92877
@teor2345
Document a wait_with_output edge case
ad52dda
@teor2345
Improve failure regex panic output
3ef8f1f
@teor2345
Improve builder ergonomics
ff1770f
@teor2345
Add internal tests for failure regex panics
e0dcb43 
It would be easy to disable these panics, and never realise.
@teor2345
Add some module structure TODOs
bf01b53
@teor2345
Stop panicking if the child process has already been taken
f566a0e
@teor2345
Add test APIs for consuming child output lines
7c0668b
@teor2345
Fix a hang on child process drop
fa0026c
@teor2345 teor2345 force-pushed the test-log-failure-regex branch from 3e2cddf to fcfc61e Compare March 20, 2022 21:40
@teor2345 teor2345 force-pushed the check-lightwalled-failures branch from 5da202f to cec838b Compare March 20, 2022 21:41
dconnolly
dconnolly approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@teor2345 teor2345 force-pushed the test-log-failure-regex branch from fcfc61e to 543db25 Compare March 22, 2022 20:37
Base automatically changed from test-log-failure-regex to main March 22, 2022 23:53
mergify bot added a commit that referenced this pull request Mar 22, 2022
@mergify
Merge of #3903
32ef8a4
@mergify mergify bot mentioned this pull request Mar 22, 2022
Closed
27 tasks
@mergify mergify bot merged commit 65c1ef8 into main Mar 23, 2022
@mergify mergify bot deleted the check-lightwalled-failures branch March 23, 2022 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dconnolly dconnolly dconnolly approved these changes

Assignees

@teor2345 teor2345

Labels
A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests lightwalletd any work associated with lightwalletd
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teor2345 @dconnolly