-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(rpc): Add Rust tests for lightwalletd sync from Zebra #4177
Conversation
@Mergifyio update |
✅ Branch has been successfully updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! There's just one minor tweak, to avoid having duplicate environment variables with different names after resolving any merge conflicts.
When rebasing on The |
Failed due to #4234:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is ok to merge this now as it will conflict with some other code i am working on. The comment from @jvff was addressed and it also looks good to me.
Motivation
We want to run full sync and quick sync integration tests for lightwalletd.
We want to merge PR #4068 first, to unblock some other work.
Depends-On: #4068
CI Commands
You'll need to update the cache paths to match the CI paths.
To test full sync:
To test quick update sync:
Manual Testing
To manually test all the lightwalletd integration tests in series (which avoids state conflicts), use:
Solution
Details:
Related Cleanups:
Closes #3511
Closes #4166
Review
@jvff is probably be the best person to review this PR.
@gustavovalverde this PR should work in CI if you use the commands above.
(It's draft because I haven't finished testing it yet.)
Reviewer Checklist
Follow Up Work