feat(ci): add fully_synced_rpc_test test to CI

[gustavovalverde]

Motivation

We want to add all completed lightwalletd integration tests to CI, to confirm we're not introducing bugs to the RPC endpoints or any other implementation related to lightwalletd

Fixes #4169
Fixes: #4305
Depends-On: #4252,#4266,#4271

Designs

• Consider the implementations being done in test.yml and test-full-sync.yml

Solution

• Add all available lightwalletd tests as different jobs to a single workflow called test-lightwalletd.yml
• Add fully_synced_rpc_test test to CI
• Add fully_synced_rpc_test to entrypoint.sh for easier execution

Review

@teor2345 or @dconnolly can review this

Reviewer Checklist

• Verify tests are using the right execution methods
• Confirm job ids, names and description
• Validate if the last test should create a disk (as being done in the full sync test right now)

Follow Up Work

Simplify this job with the refactor being done for reusable workflows

[teor2345]

I changed the base branch to PR #4177 to pick up the latest changes.

[gustavovalverde]

I changed the base branch to PR #4177 to pick up the latest changes.

@teor2345 I might be changing it back to main if the tests result are not as expected, as tests won't run if the base branch is not targeting main (should we consider changing this behavior?). If everything runs as expected, we can leave it targeting lwd-sync-test

[teor2345]

I changed the base branch to PR #4177 to pick up the latest changes.

@teor2345 I might be changing it back to main if the tests result are not as expected, as tests won't run if the base branch is not targeting main (should we consider changing this behavior?). If everything runs as expected, we can leave it targeting lwd-sync-test

No worries - we just need to pick up the latest env var change. Feel free to rebase the branch, and change the GitHub base back.

[teor2345]

Just a quick review to help with some of the Rust test details.

[teor2345]

This branch needs to be rebased on the latest #4177 changes

[teor2345]

It seems like the scope of this PR has grown a lot, so it might take a long time to get it merged.

In the test meeting, we agreed to:

• start by putting the fully synced RPC test in CI
• then put the lightwalletd full sync in CI, to generate the lightwalletd state for other tests
• then get other devs in the team to work on CI PRs for the other integration tests

This PR seems to try to cover all the tests - can we split it up, and start with the fully synced RPC test?

[teor2345]

Thanks, that looks a bit more manageable.

I think I got the order slightly wrong, I forgot we wanted to do Janito's tests next week.

So I think we might want to do a PR series like this:

1. the fully synced RPC test in CI
2. the send transaction test in CI
3. the lightwalletd full sync in CI, to generate the lightwalletd state for other tests
4. get other devs in the team to work on CI PRs for the other integration tests

What do you think? Have I missed anything else?

We've cut down the scope now

[teor2345]

I didn't do a review, but there are some syntax errors in the lints.

[gustavovalverde]

Successful run: https://github.com/ZcashFoundation/zebra/actions/runs/2272744389

[teor2345]

Thanks!

[teor2345]

The fully-synced-rpc test is not connected to the state:

May 05 01:34:27.563 WARN {net="Main"}:sync: zebrad::components::sync: could not download or verify genesis block, retrying error=DownloadFailed(Elapsed(()))

https://github.com/ZcashFoundation/zebra/runs/6299601576?check_suite_focus=true#step:8:265

We should not be seeing a genesis download in the logs.

[teor2345]

We need to connect the fully-synced-rpc test to the cached Zebra state

[teor2345]

This is ready to go, and independent of the cached tip state rebuild