-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ci): add lightwalletd_update_sync
test to CI
#4269
Conversation
This is a workaround for an issue related to disk partitioning, caused by a GCP service called Konlet, while mounting the cached disks to the VM and then to the container
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 📦📤📥🔁
The CI is working as expected now, this is failing as the While the But that issue is not related to this PR, and should be solved in https://github.com/adityapk00/lightwalletd |
So this is blocked by the lightwalletd changes? |
Considering the issue has been impacting But that's not my call. |
I'll at least fix the images name so we can ensure |
@dconnolly we got a successful run here. This one is ready from my side https://github.com/ZcashFoundation/zebra/runs/6430109707?check_suite_focus=true After merging I'll take on #4303 so we can close this initial lightwalletd cycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Motivation
We want to add all completed
lightwalletd
integration tests to CI, to confirm we're not introducing bugs to the RPC endpoints or any other implementation related tolightwalletd
Fixes #4167
Depends-On: #4268
Designs
test.yml
andtest-full-sync.yml
Solution
lightwalletd_update_sync
test to CIlightwalletd_update_sync
toentrypoint.sh
for easier executionReview
Anyone from the DevOps team can review this
Reviewer Checklist
Follow Up Work
Simplify this job with the refactor being done for reusable workflows