Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): add lightwalletd_update_sync test to CI #4269

Merged
merged 226 commits into from
May 13, 2022
Merged

Conversation

gustavovalverde
Copy link
Member

Motivation

We want to add all completed lightwalletd integration tests to CI, to confirm we're not introducing bugs to the RPC endpoints or any other implementation related to lightwalletd

Fixes #4167
Depends-On: #4268

Designs

  • Consider the implementations being done in test.yml and test-full-sync.yml

Solution

  • Add lightwalletd_update_sync test to CI
  • Add lightwalletd_update_sync to entrypoint.sh for easier execution

Review

Anyone from the DevOps team can review this

Reviewer Checklist

  • Verify tests are using the right execution methods
  • Confirm job id, step names and description

Follow Up Work

Simplify this job with the refactor being done for reusable workflows

This is a workaround for an issue related to disk partitioning, caused by a GCP service called Konlet, while mounting the cached disks to the VM and then to the container
@gustavovalverde gustavovalverde removed the do-not-merge Tells Mergify not to merge this PR label May 13, 2022
dconnolly
dconnolly previously approved these changes May 13, 2022
Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 📦📤📥🔁

Base automatically changed from lwd-ci-fullsync to main May 13, 2022 15:20
@github-actions github-actions bot requested a review from a team as a code owner May 13, 2022 15:20
@gustavovalverde
Copy link
Member Author

gustavovalverde commented May 13, 2022

The CI is working as expected now, this is failing as the lightalletd full sync is also failing due to a bug in lightwalletd, documented here https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/zcash-lightwalletd.yml#L55-L60

While the lightalletd full sync keeps failing, we won't have a disk with the new naming requirements, making the lightalletd update sync to also fail.

But that issue is not related to this PR, and should be solved in https://github.com/adityapk00/lightwalletd

@gustavovalverde gustavovalverde marked this pull request as ready for review May 13, 2022 18:22
@gustavovalverde gustavovalverde requested a review from dconnolly May 13, 2022 18:29
@dconnolly
Copy link
Contributor

dconnolly commented May 13, 2022

The CI is working as expected now, this is failing as the lightalletd full sync is also failing due to a bug in lightwalletd, documented here https://github.com/ZcashFoundation/zebra/blob/main/.github/workflows/zcash-lightwalletd.yml#L55-L60

While the lightalletd full sync keeps failing, we won't have a disk with the new naming requirements, making the lightalletd update sync to also fail.

But that issue is not related to this PR, and should be solved in https://github.com/adityapk00/lightwalletd

So this is blocked by the lightwalletd changes?

@gustavovalverde
Copy link
Member Author

gustavovalverde commented May 13, 2022

So this is blocked by the lightwalletd changes?

Considering the issue has been impacting lightwalletd_full_sync since we started working on it, and as a consequence it also has an impact on this one, but we agreed on merging lightwalletd_full_sync anyways, I'm not sure if we should block this one until a fix hits upstream lightwalletd.

But that's not my call.

@gustavovalverde
Copy link
Member Author

I'll at least fix the images name so we can ensure lightwalletd_update_sync is working before and after merging.

@gustavovalverde
Copy link
Member Author

@dconnolly we got a successful run here. This one is ready from my side https://github.com/ZcashFoundation/zebra/runs/6430109707?check_suite_focus=true

After merging I'll take on #4303 so we can close this initial lightwalletd cycle

Copy link
Contributor

@dconnolly dconnolly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-devops Area: Pipelines, CI/CD and Dockerfiles C-enhancement Category: This is an improvement I-usability Zebra is hard to understand or use lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: call lightwalletd quick tip sync test
4 participants