Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change(test): Require cached lightwalletd state for the send transaction tests #4303

Merged
merged 4 commits into from
May 13, 2022

Conversation

teor2345
Copy link
Contributor

@teor2345 teor2345 commented May 5, 2022

Motivation

After we have a cached lightwalletd image, we want to require that cached state, to speed up the tests.

This reverts part of PR #4302.

Depends-On: #4302, #4267, #4268,#4269

This also needs a DevOps change to mount the lightwalletd cached state disk.

Solution

  • require cached lightwalletd state for the send transaction tests

Review

Anyone can review this PR, it is not urgent.

Reviewer Checklist

  • Code implements Specs and Designs
  • Tests for Expected Behaviour
  • Tests for Errors

@teor2345 teor2345 added P-Medium ⚡ I-slow Problems with performance or responsiveness C-testing Category: These are tests A-rpc Area: Remote Procedure Call interfaces lightwalletd any work associated with lightwalletd labels May 5, 2022
@teor2345 teor2345 requested a review from a team as a code owner May 5, 2022 02:19
@teor2345 teor2345 self-assigned this May 5, 2022
@teor2345 teor2345 requested review from dconnolly and removed request for a team May 5, 2022 02:19
@teor2345 teor2345 added the do-not-merge Tells Mergify not to merge this PR label May 5, 2022
@teor2345 teor2345 changed the base branch from main to send-tx-no-lwd-state May 5, 2022 02:21
Base automatically changed from send-tx-no-lwd-state to main May 5, 2022 04:44
@gustavovalverde
Copy link
Member

Added #4269 as a dependency, as we're changing the way we define if a lightwalletd cache is needed there. And changes here will break when #4269 gets merged

@teor2345 teor2345 requested a review from a team as a code owner May 13, 2022 22:04
@gustavovalverde gustavovalverde removed the do-not-merge Tells Mergify not to merge this PR label May 13, 2022
@gustavovalverde
Copy link
Member

This is working as expected https://github.com/ZcashFoundation/zebra/runs/6430615895?check_suite_focus=true 🎉

@dconnolly
Copy link
Contributor

This is working as expected https://github.com/ZcashFoundation/zebra/runs/6430615895?check_suite_focus=true 🎉

🎊🦄🤩🥳🥰

Copy link
Member

@gustavovalverde gustavovalverde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gustavovalverde gustavovalverde enabled auto-merge (squash) May 13, 2022 23:01
@gustavovalverde gustavovalverde merged commit 94ba4b4 into main May 13, 2022
@gustavovalverde gustavovalverde deleted the send-tx-req-lwd-state branch May 13, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rpc Area: Remote Procedure Call interfaces C-testing Category: These are tests I-slow Problems with performance or responsiveness lightwalletd any work associated with lightwalletd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants