-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change(test): Require cached lightwalletd state for the send transaction tests #4303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teor2345
added
P-Medium ⚡
I-slow
Problems with performance or responsiveness
C-testing
Category: These are tests
A-rpc
Area: Remote Procedure Call interfaces
lightwalletd
any work associated with lightwalletd
labels
May 5, 2022
8 tasks
…send transaction tests" This reverts commit f6b29b1.
teor2345
force-pushed
the
send-tx-req-lwd-state
branch
from
May 8, 2022 22:57
064fc44
to
b5afa12
Compare
2 tasks
2 tasks
This is working as expected https://github.com/ZcashFoundation/zebra/runs/6430615895?check_suite_focus=true 🎉 |
🎊🦄🤩🥳🥰 |
gustavovalverde
approved these changes
May 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-rpc
Area: Remote Procedure Call interfaces
C-testing
Category: These are tests
I-slow
Problems with performance or responsiveness
lightwalletd
any work associated with lightwalletd
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After we have a cached lightwalletd image, we want to require that cached state, to speed up the tests.
This reverts part of PR #4302.
Depends-On: #4302, #4267, #4268,#4269
This also needs a DevOps change to mount the lightwalletd cached state disk.
Solution
Review
Anyone can review this PR, it is not urgent.
Reviewer Checklist