WIP: verbose test for #4537 #4626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #4626 +/- ##
==========================================
- Coverage 78.88% 78.84% -0.05%
==========================================
Files 306 306
Lines 37659 37661 +2
==========================================
- Hits 29708 29692 -16
- Misses 7951 7969 +18 |
|
I got the zebra log wrong (need to add a feature to get trace logging) but viewing the lightwalletd log I see calls to SendTransaction but no calls to GetMempoolStream. So it seems it's not being called for some reason? cc @oxarbitrage |
|
Now it failed during ligthwalletd sync... it seems Aditya's version can also have deadlocks |
conradoplg
force-pushed
the
issue4350_2_verbose_test
branch
from
a8d0eac to
071da50
Compare
This is a partial revert of PR #4670.
conradoplg
force-pushed
the
issue4350_2_verbose_test
branch
from
071da50 to
25a9e5a
Compare
…issue4350_2_verbose_test
|
This experimental PR is outdated and missing a lot of recent fixes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Temporary branch to investigate CI failure in #4537 by adding verbose logging to zebrad and lightwalletd. Do not merge.
Specifications
Designs
Solution
Review
Reviewer Checklist
Follow Up Work